use syntax::{ AstNode, SyntaxKind, T, ast::{self, syntax_factory::SyntaxFactory}, syntax_editor::Position, }; use crate::{AssistContext, AssistId, Assists}; // Assist: remove_parentheses // // Removes redundant parentheses. // // ``` // fn main() { // _ = $0(2) + 2; // } // ``` // -> // ``` // fn main() { // _ = 2 + 2; // } // ``` pub(crate) fn remove_parentheses(acc: &mut Assists, ctx: &AssistContext<'_>) -> Option<()> { let parens = ctx.find_node_at_offset::()?; let cursor_in_range = parens.l_paren_token()?.text_range().contains_range(ctx.selection_trimmed()) || parens.r_paren_token()?.text_range().contains_range(ctx.selection_trimmed()); if !cursor_in_range { return None; } let expr = parens.expr()?; let parent = parens.syntax().parent()?; if expr.needs_parens_in(&parent) { return None; } let target = parens.syntax().text_range(); acc.add( AssistId::refactor("remove_parentheses"), "Remove redundant parentheses", target, |builder| { let mut editor = builder.make_editor(parens.syntax()); let prev_token = parens.syntax().first_token().and_then(|it| it.prev_token()); let need_to_add_ws = match prev_token { Some(it) => { let tokens = [T![&], T![!], T!['('], T!['['], T!['{']]; it.kind() != SyntaxKind::WHITESPACE && !tokens.contains(&it.kind()) } None => false, }; if need_to_add_ws { let make = SyntaxFactory::with_mappings(); editor.insert(Position::before(parens.syntax()), make.whitespace(" ")); editor.add_mappings(make.finish_with_mappings()); } editor.replace(parens.syntax(), expr.syntax()); builder.add_file_edits(ctx.vfs_file_id(), editor); }, ) } #[cfg(test)] mod tests { use crate::tests::{check_assist, check_assist_not_applicable}; use super::*; #[test] fn remove_parens_space() { check_assist( remove_parentheses, r#"fn f() { match$0(true) {} }"#, r#"fn f() { match true {} }"#, ); } #[test] fn remove_parens_simple() { check_assist(remove_parentheses, r#"fn f() { $0(2) + 2; }"#, r#"fn f() { 2 + 2; }"#); check_assist(remove_parentheses, r#"fn f() { ($02) + 2; }"#, r#"fn f() { 2 + 2; }"#); check_assist(remove_parentheses, r#"fn f() { (2)$0 + 2; }"#, r#"fn f() { 2 + 2; }"#); check_assist(remove_parentheses, r#"fn f() { (2$0) + 2; }"#, r#"fn f() { 2 + 2; }"#); } #[test] fn remove_parens_closure() { check_assist(remove_parentheses, r#"fn f() { &$0(|| 42) }"#, r#"fn f() { &|| 42 }"#); check_assist_not_applicable(remove_parentheses, r#"fn f() { $0(|| 42).f() }"#); } #[test] fn remove_parens_if_let_chains() { check_assist_not_applicable( remove_parentheses, r#"fn f() { if let true = $0(true && true) {} }"#, ); } #[test] fn remove_parens_associativity() { check_assist( remove_parentheses, r#"fn f() { $0(2 + 2) + 2; }"#, r#"fn f() { 2 + 2 + 2; }"#, ); check_assist_not_applicable(remove_parentheses, r#"fn f() { 2 + $0(2 + 2); }"#); } #[test] fn remove_parens_precedence() { check_assist( remove_parentheses, r#"fn f() { $0(2 * 3) + 1; }"#, r#"fn f() { 2 * 3 + 1; }"#, ); check_assist(remove_parentheses, r#"fn f() { ( $0(2) ); }"#, r#"fn f() { ( 2 ); }"#); check_assist(remove_parentheses, r#"fn f() { $0(2?)?; }"#, r#"fn f() { 2??; }"#); check_assist(remove_parentheses, r#"fn f() { f(($02 + 2)); }"#, r#"fn f() { f(2 + 2); }"#); check_assist( remove_parentheses, r#"fn f() { (1<2) &&$0(3>4); }"#, r#"fn f() { (1<2) && 3>4; }"#, ); } #[test] fn remove_parens_doesnt_apply_precedence() { check_assist_not_applicable(remove_parentheses, r#"fn f() { $0(2 + 2) * 8; }"#); check_assist_not_applicable(remove_parentheses, r#"fn f() { $0(2 + 2).f(); }"#); check_assist_not_applicable(remove_parentheses, r#"fn f() { $0(2 + 2).await; }"#); check_assist_not_applicable(remove_parentheses, r#"fn f() { $0!(2..2); }"#); } #[test] fn remove_parens_doesnt_apply_with_cursor_not_on_paren() { check_assist_not_applicable(remove_parentheses, r#"fn f() { (2 +$0 2) }"#); check_assist_not_applicable(remove_parentheses, r#"fn f() {$0 (2 + 2) }"#); } #[test] fn remove_parens_doesnt_apply_when_expr_would_be_turned_into_a_statement() { check_assist_not_applicable(remove_parentheses, r#"fn x() -> u8 { $0({ 0 } + 1) }"#); check_assist_not_applicable( remove_parentheses, r#"fn x() -> u8 { $0(if true { 0 } else { 1 } + 1) }"#, ); check_assist_not_applicable(remove_parentheses, r#"fn x() -> u8 { $0(loop {} + 1) }"#); } #[test] fn remove_parens_doesnt_apply_weird_syntax_and_edge_cases() { // removing `()` would break code because {} would be counted as the loop/if body check_assist_not_applicable(remove_parentheses, r#"fn f() { for _ in $0(0..{3}) {} }"#); check_assist_not_applicable(remove_parentheses, r#"fn f() { for _ in $0(S {}) {} }"#); check_assist_not_applicable(remove_parentheses, r#"fn f() { if $0(S {} == 2) {} }"#); check_assist_not_applicable(remove_parentheses, r#"fn f() { if $0(return) {} }"#); } #[test] fn remove_parens_prefix_with_ret_like_prefix() { check_assist(remove_parentheses, r#"fn f() { !$0(return) }"#, r#"fn f() { !return }"#); // `break`, `continue` behave the same under prefix operators check_assist(remove_parentheses, r#"fn f() { !$0(break) }"#, r#"fn f() { !break }"#); check_assist(remove_parentheses, r#"fn f() { !$0(continue) }"#, r#"fn f() { !continue }"#); check_assist( remove_parentheses, r#"fn f() { !$0(return false) }"#, r#"fn f() { !return false }"#, ); // Binary operators should still allow removal unless a ret-like expression is immediately followed by `||` or `&&`. check_assist( remove_parentheses, r#"fn f() { true || $0(return) }"#, r#"fn f() { true || return }"#, ); check_assist( remove_parentheses, r#"fn f() { cond && $0(return) }"#, r#"fn f() { cond && return }"#, ); } #[test] fn remove_parens_return_with_value_followed_by_block() { check_assist( remove_parentheses, r#"fn f() { if $0(return ()) {} }"#, r#"fn f() { if return () {} }"#, ); } #[test] fn remove_exprs_let_else_restrictions() { // `}` is not allowed before `else` here check_assist_not_applicable( remove_parentheses, r#"fn f() { let _ = $0(S{}) else { return }; }"#, ); // logic operators can't directly appear in the let-else check_assist_not_applicable( remove_parentheses, r#"fn f() { let _ = $0(false || false) else { return }; }"#, ); check_assist_not_applicable( remove_parentheses, r#"fn f() { let _ = $0(true && true) else { return }; }"#, ); } #[test] fn remove_parens_weird_places() { check_assist( remove_parentheses, r#"fn f() { match () { _ =>$0(()) } }"#, r#"fn f() { match () { _ => () } }"#, ); check_assist( remove_parentheses, r#"fn x() -> u8 { { [$0({ 0 } + 1)] } }"#, r#"fn x() -> u8 { { [{ 0 } + 1] } }"#, ); } #[test] fn remove_parens_return_dot_f() { check_assist( remove_parentheses, r#"fn f() { $0(return).f() }"#, r#"fn f() { return.f() }"#, ); } #[test] fn remove_parens_prefix_then_return_something() { check_assist( remove_parentheses, r#"fn f() { &$0(return ()) }"#, r#"fn f() { &return () }"#, ); } #[test] fn remove_parens_return_in_unary_not() { check_assist( remove_parentheses, r#"fn f() { cond && !$0(return) }"#, r#"fn f() { cond && !return }"#, ); check_assist( remove_parentheses, r#"fn f() { cond && !$0(return false) }"#, r#"fn f() { cond && !return false }"#, ); } #[test] fn remove_parens_return_in_disjunction_with_closure_risk() { // `return` may only be blocked when it would form `return ||` or `return &&` check_assist_not_applicable( remove_parentheses, r#"fn f() { let _x = true && $0(return) || true; }"#, ); check_assist_not_applicable( remove_parentheses, r#"fn f() { let _x = true && !$0(return) || true; }"#, ); check_assist_not_applicable( remove_parentheses, r#"fn f() { let _x = true && $0(return false) || true; }"#, ); check_assist_not_applicable( remove_parentheses, r#"fn f() { let _x = true && !$0(return false) || true; }"#, ); check_assist_not_applicable( remove_parentheses, r#"fn f() { let _x = true && $0(return) && true; }"#, ); check_assist_not_applicable( remove_parentheses, r#"fn f() { let _x = true && !$0(return) && true; }"#, ); check_assist_not_applicable( remove_parentheses, r#"fn f() { let _x = true && $0(return false) && true; }"#, ); check_assist_not_applicable( remove_parentheses, r#"fn f() { let _x = true && !$0(return false) && true; }"#, ); check_assist_not_applicable( remove_parentheses, r#"fn f() { let _x = $0(return) || true; }"#, ); check_assist_not_applicable( remove_parentheses, r#"fn f() { let _x = $0(return) && true; }"#, ); } #[test] fn remove_parens_return_in_disjunction_is_ok() { check_assist( remove_parentheses, r#"fn f() { let _x = true || $0(return); }"#, r#"fn f() { let _x = true || return; }"#, ); check_assist( remove_parentheses, r#"fn f() { let _x = true && $0(return); }"#, r#"fn f() { let _x = true && return; }"#, ); } #[test] fn remove_parens_conflict_cast_before_l_angle() { check_assist_not_applicable(remove_parentheses, r#"fn f() { _ = $0(1 as u32) << 10; }"#); check_assist_not_applicable(remove_parentheses, r#"fn f() { _ = $0(1 as u32) < 10; }"#); } #[test] fn remove_parens_double_paren_stmt() { check_assist( remove_parentheses, r#"fn x() -> u8 { $0(({ 0 } + 1)) }"#, r#"fn x() -> u8 { ({ 0 } + 1) }"#, ); check_assist( remove_parentheses, r#"fn x() -> u8 { (($0{ 0 } + 1)) }"#, r#"fn x() -> u8 { ({ 0 } + 1) }"#, ); } #[test] fn remove_parens_im_tired_of_naming_tests() { check_assist( remove_parentheses, r#"fn f() { 2 + $0(return 2) }"#, r#"fn f() { 2 + return 2 }"#, ); check_assist_not_applicable(remove_parentheses, r#"fn f() { $0(return 2) + 2 }"#); } #[test] fn remove_parens_indirect_calls() { check_assist( remove_parentheses, r#"fn f(call: fn(usize), arg: usize) { $0(call)(arg); }"#, r#"fn f(call: fn(usize), arg: usize) { call(arg); }"#, ); check_assist( remove_parentheses, r#"fn f(call: F, arg: usize) where F: Fn(usize) { $0(call)(arg); }"#, r#"fn f(call: F, arg: usize) where F: Fn(usize) { call(arg); }"#, ); // Parentheses are necessary when calling a function-like pointer that is a member of a struct or union. check_assist_not_applicable( remove_parentheses, r#" struct Foo { t: T, } impl Foo { fn foo(&self, arg: usize) { $0(self.t)(arg); } }"#, ); } }