rust-analyzer - Unnamed repository; edit this file 'description' to name the repository.


1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110

use crate::{Diagnostic, DiagnosticCode, DiagnosticsContext};

// Diagnostic: elided-lifetimes-in-path
//
// This diagnostic is triggered when lifetimes are elided in paths. It is a lint only for some cases,
// and a hard error for others.
pub(crate) fn elided_lifetimes_in_path(
    ctx: &DiagnosticsContext<'_>,
    d: &hir::ElidedLifetimesInPath,
) -> Diagnostic {
    if d.hard_error {
        Diagnostic::new_with_syntax_node_ptr(
            ctx,
            DiagnosticCode::RustcHardError("E0726"),
            "implicit elided lifetime not allowed here",
            d.generics_or_segment.map(Into::into),
        )
    } else {
        Diagnostic::new_with_syntax_node_ptr(
            ctx,
            DiagnosticCode::RustcLint("elided_lifetimes_in_paths"),
            "hidden lifetime parameters in types are deprecated",
            d.generics_or_segment.map(Into::into),
        )
    }
}

#[cfg(test)]
mod tests {
    use crate::tests::check_diagnostics;

    #[test]
    fn fn_() {
        check_diagnostics(
            r#"
#![warn(elided_lifetimes_in_paths)]

struct Foo<'a>(&'a ());

fn foo(_: Foo) {}
       // ^^^ warn: hidden lifetime parameters in types are deprecated
        "#,
        );
        check_diagnostics(
            r#"
#![warn(elided_lifetimes_in_paths)]

struct Foo<'a>(&'a ());

fn foo(_: Foo<'_>) -> Foo { loop {} }
                   // ^^^ warn: hidden lifetime parameters in types are deprecated
        "#,
        );
    }

    #[test]
    fn async_fn() {
        check_diagnostics(
            r#"
struct Foo<'a>(&'a ());

async fn foo(_: Foo) {}
             // ^^^ error: implicit elided lifetime not allowed here
        "#,
        );
        check_diagnostics(
            r#"
#![warn(elided_lifetimes_in_paths)]

struct Foo<'a>(&'a ());

fn foo(_: Foo<'_>) -> Foo { loop {} }
                   // ^^^ warn: hidden lifetime parameters in types are deprecated
        "#,
        );
    }

    #[test]
    fn no_error_when_explicitly_elided() {
        check_diagnostics(
            r#"
#![warn(elided_lifetimes_in_paths)]

struct Foo<'a>(&'a ());
trait Trait<'a> {}

fn foo(_: Foo<'_>) -> Foo<'_> { loop {} }
async fn bar(_: Foo<'_>) -> Foo<'_> { loop {} }
impl Foo<'_> {}
impl Trait<'_> for Foo<'_> {}
        "#,
        );
    }

    #[test]
    fn impl_() {
        check_diagnostics(
            r#"
struct Foo<'a>(&'a ());
trait Trait<'a> {}

impl Foo {}
  // ^^^ error: implicit elided lifetime not allowed here

impl Trait for Foo<'_> {}
  // ^^^^^ error: implicit elided lifetime not allowed here
        "#,
        );
    }
}