Unnamed repository; edit this file 'description' to name the repository.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
use hir::{HasSource, HirDisplay, db::ExpandDatabase};
use ide_db::text_edit::TextRange;
use ide_db::{
    assists::{Assist, AssistId},
    label::Label,
    source_change::SourceChangeBuilder,
};
use syntax::{
    AstNode, ToSmolStr,
    ast::{HasName, edit::AstNodeEdit},
};

use crate::{Diagnostic, DiagnosticCode, DiagnosticsContext};

// Diagnostic: trait-impl-redundant-assoc_item
//
// Diagnoses redundant trait items in a trait impl.
pub(crate) fn trait_impl_redundant_assoc_item(
    ctx: &DiagnosticsContext<'_, '_>,
    d: &hir::TraitImplRedundantAssocItems,
) -> Diagnostic {
    let db = ctx.sema.db;
    let name = d.assoc_item.0.clone();
    let redundant_assoc_item_name = name.display(db, ctx.edition);
    let assoc_item = d.assoc_item.1;

    let default_range = d.impl_.syntax_node_ptr().text_range();
    let trait_name = d.trait_.name(db).display_no_db(ctx.edition).to_smolstr();
    let indent_level = d.trait_.source(db).map_or(0, |it| it.value.indent_level().0) + 1;

    let (redundant_item_name, diagnostic_range, redundant_item_def) = match assoc_item {
        hir::AssocItem::Function(id) => {
            let function = id;
            (
                format!("`fn {redundant_assoc_item_name}`"),
                function.source(db).map(|it| it.syntax().text_range()).unwrap_or(default_range),
                format!("\n{};", function.display(db, ctx.display_target)),
            )
        }
        hir::AssocItem::Const(id) => {
            let constant = id;
            (
                format!("`const {redundant_assoc_item_name}`"),
                constant.source(db).map(|it| it.syntax().text_range()).unwrap_or(default_range),
                format!("\n{};", constant.display(db, ctx.display_target)),
            )
        }
        hir::AssocItem::TypeAlias(id) => {
            let type_alias = id;
            (
                format!("`type {redundant_assoc_item_name}`"),
                type_alias.source(db).map(|it| it.syntax().text_range()).unwrap_or(default_range),
                // FIXME cannot generate generic parameter and bounds
                format!("\ntype {};", type_alias.name(ctx.sema.db).display_no_db(ctx.edition)),
            )
        }
    };

    let hir::FileRange { file_id, range } =
        hir::InFile::new(d.file_id, diagnostic_range).original_node_file_range_rooted(db);
    Diagnostic::new(
        DiagnosticCode::RustcHardError("E0407"),
        format!("{redundant_item_name} is not a member of trait `{trait_name}`"),
        ide_db::FileRange { file_id: file_id.file_id(ctx.sema.db), range },
    )
    .stable()
    .with_fixes(quickfix_for_redundant_assoc_item(
        ctx,
        d,
        stdx::indent_string(&redundant_item_def, indent_level),
        diagnostic_range,
    ))
}

/// add assoc item into the trait def body
fn quickfix_for_redundant_assoc_item(
    ctx: &DiagnosticsContext<'_, '_>,
    d: &hir::TraitImplRedundantAssocItems,
    redundant_item_def: String,
    range: TextRange,
) -> Option<Vec<Assist>> {
    let file_id = d.file_id.file_id()?;
    let add_assoc_item_def = |builder: &mut SourceChangeBuilder| -> Option<()> {
        let db = ctx.sema.db;
        let root = db.parse_or_expand(d.file_id);
        // don't modify trait def in outer crate
        let impl_def = d.impl_.to_node(&root);
        let current_crate = ctx.sema.scope(impl_def.syntax())?.krate();
        let trait_def_crate = d.trait_.module(db).krate(db);
        if trait_def_crate != current_crate {
            return None;
        }

        let trait_def = d.trait_.source(db)?.value;
        let insert_after = find_insert_after(range, &impl_def, &trait_def)?;

        let where_to_insert =
            hir::InFile::new(d.file_id, insert_after).original_node_file_range_rooted_opt(db)?;
        if where_to_insert.file_id != file_id {
            return None;
        }

        builder.insert(where_to_insert.range.end(), redundant_item_def);
        Some(())
    };
    let mut source_change_builder = SourceChangeBuilder::new(file_id.file_id(ctx.sema.db));
    add_assoc_item_def(&mut source_change_builder)?;

    Some(vec![Assist {
        id: AssistId::quick_fix("add assoc item def into trait def"),
        label: Label::new("Add assoc item def into trait def".to_owned()),
        group: None,
        target: range,
        source_change: Some(source_change_builder.finish()),
        command: None,
    }])
}

fn find_insert_after(
    redundant_range: TextRange,
    impl_def: &syntax::ast::Impl,
    trait_def: &syntax::ast::Trait,
) -> Option<TextRange> {
    let impl_items_before_redundant = impl_def
        .assoc_item_list()?
        .assoc_items()
        .take_while(|it| it.syntax().text_range().start() < redundant_range.start())
        .filter_map(|it| name_of(&it))
        .collect::<Vec<_>>();

    let after_item = trait_def
        .assoc_item_list()?
        .assoc_items()
        .filter(|it| {
            name_of(it).is_some_and(|name| {
                impl_items_before_redundant.iter().any(|it| it.text() == name.text())
            })
        })
        .last()
        .map(|it| it.syntax().text_range());

    return after_item.or_else(|| Some(trait_def.assoc_item_list()?.l_curly_token()?.text_range()));

    fn name_of(it: &syntax::ast::AssocItem) -> Option<syntax::ast::Name> {
        match it {
            syntax::ast::AssocItem::Const(it) => it.name(),
            syntax::ast::AssocItem::Fn(it) => it.name(),
            syntax::ast::AssocItem::TypeAlias(it) => it.name(),
            syntax::ast::AssocItem::MacroCall(_) => None,
        }
    }
}

#[cfg(test)]
mod tests {
    use crate::tests::{check_diagnostics, check_fix, check_no_fix};

    #[test]
    fn quickfix_for_assoc_func() {
        check_fix(
            r#"
trait Marker {
    fn boo();
}
struct Foo;
impl Marker for Foo {
    fn$0 bar(_a: i32, _b: String) -> String {}
    fn boo() {}
}
            "#,
            r#"
trait Marker {
    fn bar(_a: i32, _b: String) -> String;
    fn boo();
}
struct Foo;
impl Marker for Foo {
    fn bar(_a: i32, _b: String) -> String {}
    fn boo() {}
}
            "#,
        )
    }

    #[test]
    fn quickfix_for_assoc_const() {
        check_fix(
            r#"
trait Marker {
    fn foo () {}
}
struct Foo;
impl Marker for Foo {
    const FLAG: bool$0 = false;
}
            "#,
            r#"
trait Marker {
    const FLAG: bool;
    fn foo () {}
}
struct Foo;
impl Marker for Foo {
    const FLAG: bool = false;
}
            "#,
        )
    }

    #[test]
    fn quickfix_for_assoc_type() {
        check_fix(
            r#"
trait Marker {
}
struct Foo;
impl Marker for Foo {
    type T = i32;$0
}
            "#,
            r#"
trait Marker {
    type T;
}
struct Foo;
impl Marker for Foo {
    type T = i32;
}
            "#,
        )
    }

    #[test]
    fn quickfix_indentations() {
        check_fix(
            r#"
mod indent {
    trait Marker {
        fn boo();
    }
    struct Foo;
    impl Marker for Foo {
        fn$0 bar<T: Copy>(_a: i32, _b: T) -> String {}
        fn boo() {}
    }
}
            "#,
            r#"
mod indent {
    trait Marker {
        fn bar<T>(_a: i32, _b: T) -> String
        where
            T: Copy,;
        fn boo();
    }
    struct Foo;
    impl Marker for Foo {
        fn bar<T: Copy>(_a: i32, _b: T) -> String {}
        fn boo() {}
    }
}
            "#,
        );

        check_fix(
            r#"
mod indent {
    trait Marker {
        fn foo () {}
    }
    struct Foo;
    impl Marker for Foo {
        const FLAG: bool$0 = false;
    }
}
            "#,
            r#"
mod indent {
    trait Marker {
        const FLAG: bool;
        fn foo () {}
    }
    struct Foo;
    impl Marker for Foo {
        const FLAG: bool = false;
    }
}
            "#,
        );

        check_fix(
            r#"
mod indent {
    trait Marker {
    }
    struct Foo;
    impl Marker for Foo {
        type T = i32;$0
    }
}
            "#,
            r#"
mod indent {
    trait Marker {
        type T;
    }
    struct Foo;
    impl Marker for Foo {
        type T = i32;
    }
}
            "#,
        );
    }

    #[test]
    fn quickfix_order() {
        check_fix(
            r#"
trait Marker {
    fn foo();
    fn baz();
}
struct Foo;
impl Marker for Foo {
    fn foo() {}
    fn missing() {}$0
    fn baz() {}
}
            "#,
            r#"
trait Marker {
    fn foo();
    fn missing();
    fn baz();
}
struct Foo;
impl Marker for Foo {
    fn foo() {}
    fn missing() {}
    fn baz() {}
}
            "#,
        );

        check_fix(
            r#"
trait Marker {
    type Item;
    fn bar();
    fn baz();
}
struct Foo;
impl Marker for Foo {
    type Item = Foo;
    fn missing() {}$0
    fn bar() {}
    fn baz() {}
}
            "#,
            r#"
trait Marker {
    type Item;
    fn missing();
    fn bar();
    fn baz();
}
struct Foo;
impl Marker for Foo {
    type Item = Foo;
    fn missing() {}
    fn bar() {}
    fn baz() {}
}
            "#,
        );
    }

    #[test]
    fn quickfix_dont_work() {
        check_no_fix(
            r#"
            //- /dep.rs crate:dep
            trait Marker {
            }
            //- /main.rs crate:main deps:dep
            struct Foo;
            impl dep::Marker for Foo {
                type T = i32;$0
            }
            "#,
        )
    }

    #[test]
    fn trait_with_default_value() {
        check_diagnostics(
            r#"
trait Marker {
    const FLAG: bool = false;
    fn boo();
    fn foo () {}
}
struct Foo;
impl Marker for Foo {
    type T = i32;
  //^^^^^^^^^^^^^ 💡 error: `type T` is not a member of trait `Marker`

    const FLAG: bool = true;

    fn bar() {}
  //^^^^^^^^^^^ 💡 error: `fn bar` is not a member of trait `Marker`

    fn boo() {}
}
            "#,
        )
    }

    #[test]
    fn dont_work_for_negative_impl() {
        check_diagnostics(
            r#"
trait Marker {
    const FLAG: bool = false;
    fn boo();
    fn foo () {}
}
struct Foo;
impl !Marker for Foo {
    type T = i32;
    const FLAG: bool = true;
    fn bar() {}
    fn boo() {}
}
            "#,
        )
    }
}