bendns' repos / cgit
the repository which powers this website
Always #include corresponding .h in .c files
While doing this, remove declarations from header files where the corresponding definition is declared "static" in order to avoid build errors. Also re-order existing headers in ui-*.c so that the file-specific header always comes immediately after "cgit.h", helping with future consistency. Signed-off-by: John Keeping <[email protected]>
Browse Source
John Keeping 2013-04-08
parent a5e4ad2 · commit 8f20879
Diffstat
-rw-r--r--html.c1
-rw-r--r--html.h2
-rw-r--r--scan-tree.c1
-rw-r--r--ui-atom.c1
-rw-r--r--ui-blob.c1
-rw-r--r--ui-clone.c1
-rw-r--r--ui-commit.c1
-rw-r--r--ui-diff.c1
-rw-r--r--ui-diff.h3
-rw-r--r--ui-log.c1
-rw-r--r--ui-patch.c1
-rw-r--r--ui-plain.c1
-rw-r--r--ui-refs.c1
-rw-r--r--ui-repolist.c1
-rw-r--r--ui-shared.c1
-rw-r--r--ui-shared.h2
-rw-r--r--ui-snapshot.c1
-rw-r--r--ui-ssdiff.c2
-rw-r--r--ui-stats.c2
-rw-r--r--ui-summary.c1
-rw-r--r--ui-tag.c1
-rw-r--r--ui-tree.c1
22 files changed, 20 insertions, 8 deletions
diff --git a/html.c b/html.c
index d60a41ff..1104f97f 100644
--- a/html.c
+++ b/html.c
@@ -6,6 +6,7 @@
* (see COPYING for full license text)
*/
+#include "html.h"
#include <unistd.h>
#include <stdio.h>
#include <stdlib.h>
diff --git a/html.h b/html.h
index 20e1dc21..bb36f376 100644
--- a/html.h
+++ b/html.h
@@ -1,7 +1,7 @@
#ifndef HTML_H
#define HTML_H
-extern int htmlfd;
+#include <stddef.h>
extern void html_raw(const char *txt, size_t size);
extern void html(const char *txt);
diff --git a/scan-tree.c b/scan-tree.c
index 10d90f49..0d3e0ade 100644
--- a/scan-tree.c
+++ b/scan-tree.c
@@ -8,6 +8,7 @@
*/
#include "cgit.h"
+#include "scan-tree.h"
#include "configfile.h"
#include "html.h"
diff --git a/ui-atom.c b/ui-atom.c
index 15540889..2a1eb595 100644
--- a/ui-atom.c
+++ b/ui-atom.c
@@ -7,6 +7,7 @@
*/
#include "cgit.h"
+#include "ui-atom.h"
#include "html.h"
#include "ui-shared.h"
diff --git a/ui-blob.c b/ui-blob.c
index 7aec0b17..1da43c81 100644
--- a/ui-blob.c
+++ b/ui-blob.c
@@ -8,6 +8,7 @@
*/
#include "cgit.h"
+#include "ui-blob.h"
#include "html.h"
#include "ui-shared.h"
diff --git a/ui-clone.c b/ui-clone.c
index fdea24f3..30d020e4 100644
--- a/ui-clone.c
+++ b/ui-clone.c
@@ -8,6 +8,7 @@
*/
#include "cgit.h"
+#include "ui-clone.h"
#include "html.h"
#include "ui-shared.h"
diff --git a/ui-commit.c b/ui-commit.c
index 5a552a19..8310ce66 100644
--- a/ui-commit.c
+++ b/ui-commit.c
@@ -7,6 +7,7 @@
*/
#include "cgit.h"
+#include "ui-commit.h"
#include "html.h"
#include "ui-shared.h"
#include "ui-diff.h"
diff --git a/ui-diff.c b/ui-diff.c
index 7de7802b..11155185 100644
--- a/ui-diff.c
+++ b/ui-diff.c
@@ -7,6 +7,7 @@
*/
#include "cgit.h"
+#include "ui-diff.h"
#include "html.h"
#include "ui-shared.h"
#include "ui-ssdiff.h"
diff --git a/ui-diff.h b/ui-diff.h
index 0161ffb2..25a92969 100644
--- a/ui-diff.h
+++ b/ui-diff.h
@@ -3,9 +3,6 @@
extern void cgit_print_diff_ctrls();
-extern void cgit_print_diffstat(const unsigned char *old_sha1,
- const unsigned char *new_sha1);
-
extern void cgit_print_diff(const char *new_hex, const char *old_hex,
const char *prefix, int show_ctrls);
diff --git a/ui-log.c b/ui-log.c
index 8d8b2351..8592843c 100644
--- a/ui-log.c
+++ b/ui-log.c
@@ -7,6 +7,7 @@
*/
#include "cgit.h"
+#include "ui-log.h"
#include "html.h"
#include "ui-shared.h"
#include "vector.h"
diff --git a/ui-patch.c b/ui-patch.c
index 12abe102..66def3c9 100644
--- a/ui-patch.c
+++ b/ui-patch.c
@@ -7,6 +7,7 @@
*/
#include "cgit.h"
+#include "ui-patch.h"
#include "html.h"
#include "ui-shared.h"
diff --git a/ui-plain.c b/ui-plain.c
index 8ef4ec6b..4397a59e 100644
--- a/ui-plain.c
+++ b/ui-plain.c
@@ -8,6 +8,7 @@
#include <stdio.h>
#include "cgit.h"
+#include "ui-plain.h"
#include "html.h"
#include "ui-shared.h"
diff --git a/ui-refs.c b/ui-refs.c
index 45db2ac1..5bebed1e 100644
--- a/ui-refs.c
+++ b/ui-refs.c
@@ -7,6 +7,7 @@
*/
#include "cgit.h"
+#include "ui-refs.h"
#include "html.h"
#include "ui-shared.h"
diff --git a/ui-repolist.c b/ui-repolist.c
index a9751f6f..76fe71a9 100644
--- a/ui-repolist.c
+++ b/ui-repolist.c
@@ -8,6 +8,7 @@
*/
#include "cgit.h"
+#include "ui-repolist.h"
#include "html.h"
#include "ui-shared.h"
#include <strings.h>
diff --git a/ui-shared.c b/ui-shared.c
index 7a726c19..945d560a 100644
--- a/ui-shared.c
+++ b/ui-shared.c
@@ -7,6 +7,7 @@
*/
#include "cgit.h"
+#include "ui-shared.h"
#include "cmd.h"
#include "html.h"
diff --git a/ui-shared.h b/ui-shared.h
index 06663884..5f8b6295 100644
--- a/ui-shared.h
+++ b/ui-shared.h
@@ -47,8 +47,6 @@ extern void cgit_diff_link(const char *name, const char *title,
extern void cgit_stats_link(const char *name, const char *title,
const char *class, const char *head,
const char *path);
-extern void cgit_self_link(char *name, const char *title,
- const char *class, struct cgit_context *ctx);
extern void cgit_object_link(struct object *obj);
extern void cgit_submodule_link(const char *class, char *path,
diff --git a/ui-snapshot.c b/ui-snapshot.c
index e199a92d..9be5dbef 100644
--- a/ui-snapshot.c
+++ b/ui-snapshot.c
@@ -8,6 +8,7 @@
*/
#include "cgit.h"
+#include "ui-snapshot.h"
#include "html.h"
#include "ui-shared.h"
diff --git a/ui-ssdiff.c b/ui-ssdiff.c
index 3d3dad68..cbe60bd6 100644
--- a/ui-ssdiff.c
+++ b/ui-ssdiff.c
@@ -1,8 +1,8 @@
#include "cgit.h"
+#include "ui-ssdiff.h"
#include "html.h"
#include "ui-shared.h"
#include "ui-diff.h"
-#include "ui-ssdiff.h"
extern int use_ssdiff;
diff --git a/ui-stats.c b/ui-stats.c
index 480c8eec..52e9b91b 100644
--- a/ui-stats.c
+++ b/ui-stats.c
@@ -1,7 +1,7 @@
#include "cgit.h"
+#include "ui-stats.h"
#include "html.h"
#include "ui-shared.h"
-#include "ui-stats.h"
#ifdef NO_C99_FORMAT
#define SZ_FMT "%u"
diff --git a/ui-summary.c b/ui-summary.c
index 0754bb7f..bd123ef4 100644
--- a/ui-summary.c
+++ b/ui-summary.c
@@ -8,6 +8,7 @@
*/
#include "cgit.h"
+#include "ui-summary.h"
#include "html.h"
#include "ui-log.h"
#include "ui-refs.h"
diff --git a/ui-tag.c b/ui-tag.c
index 4d340d4b..5a22696a 100644
--- a/ui-tag.c
+++ b/ui-tag.c
@@ -7,6 +7,7 @@
*/
#include "cgit.h"
+#include "ui-tag.h"
#include "html.h"
#include "ui-shared.h"
diff --git a/ui-tree.c b/ui-tree.c
index b692b563..d7135532 100644
--- a/ui-tree.c
+++ b/ui-tree.c
@@ -8,6 +8,7 @@
#include <ctype.h>
#include "cgit.h"
+#include "ui-tree.h"
#include "html.h"
#include "ui-shared.h"