Unnamed repository; edit this file 'description' to name the repository.
Fix scrollbar length proportional to total menu items (#2860)
The scrollbar length used to increase with more entries in the menu, which was counter-intuitive to how scrollbars worked in most applications. Turns out there was a typo in the floor division implementation :)
Gokul Soumya 2022-06-23
parent b365f2d · commit 301065f
-rw-r--r--helix-term/src/ui/menu.rs2
1 files changed, 1 insertions, 1 deletions
diff --git a/helix-term/src/ui/menu.rs b/helix-term/src/ui/menu.rs
index d67a429e..477b218a 100644
--- a/helix-term/src/ui/menu.rs
+++ b/helix-term/src/ui/menu.rs
@@ -288,7 +288,7 @@ impl<T: Item + 'static> Component for Menu<T> {
let win_height = area.height as usize;
const fn div_ceil(a: usize, b: usize) -> usize {
- (a + b - 1) / a
+ (a + b - 1) / b
}
let scroll_height = std::cmp::min(div_ceil(win_height.pow(2), len), win_height as usize);