Unnamed repository; edit this file 'description' to name the repository.
Avoid unnecessary clone when formatting error (#1903)
Instead of first cloning the query and then allocating again to format
the error, format the error using a reference to the query.
| -rw-r--r-- | helix-term/src/commands.rs | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/helix-term/src/commands.rs b/helix-term/src/commands.rs index f4844170..29648039 100644 --- a/helix-term/src/commands.rs +++ b/helix-term/src/commands.rs @@ -1646,11 +1646,8 @@ fn search_next_or_prev_impl(cx: &mut Context, movement: Movement, direction: Dir wrap_around, ); } else { - // get around warning `mutable_borrow_reservation_conflict` - // which will be a hard error in the future - // see: https://github.com/rust-lang/rust/issues/59159 - let query = query.clone(); - cx.editor.set_error(format!("Invalid regex: {}", query)); + let error = format!("Invalid regex: {}", query); + cx.editor.set_error(error); } } } |