Unnamed repository; edit this file 'description' to name the repository.
Avoid cloning language server names in Document::save
`language_servers` is a `HashMap<String, Arc<Client>>` so the clients are cheap to clone but not the language server names. The names are unused in the save future so we can avoid the unnecessary clones by looking only at the `HashMap::values`.
Michael Davis 5 months ago
parent a5d0a0e · commit ce351f4
-rw-r--r--helix-view/src/document.rs4
1 files changed, 2 insertions, 2 deletions
diff --git a/helix-view/src/document.rs b/helix-view/src/document.rs
index 28b8fa94..e52dbe0f 100644
--- a/helix-view/src/document.rs
+++ b/helix-view/src/document.rs
@@ -980,7 +980,7 @@ impl Document {
};
let identifier = self.path().map(|_| self.identifier());
- let language_servers = self.language_servers.clone();
+ let language_servers: Vec<_> = self.language_servers.values().cloned().collect();
// mark changes up to now as saved
let current_rev = self.get_current_revision();
@@ -1124,7 +1124,7 @@ impl Document {
text: text.clone(),
};
- for (_, language_server) in language_servers {
+ for language_server in language_servers {
if !language_server.is_initialized() {
continue;
}