Unnamed repository; edit this file 'description' to name the repository.
Fix lacking space panic (#6109)
* Fix lack of space for popup crash * Fix saturating -> wrapping * Fix wrapping -> saturating (I am an idiot) * Remove useless "mut" in helix-tui/src/buffer.rs Co-authored-by: Michael Davis <[email protected]> * Remove redundant bound-check * Return bound-check back * Add bound-check for set_style * Remove set_style bound-check * Revert bound-check --------- Co-authored-by: Michael Davis <[email protected]>
nuid32 2023-03-05
parent ccdb144 · commit def2696
-rw-r--r--helix-term/src/ui/markdown.rs5
-rw-r--r--helix-view/src/graphics.rs4
2 files changed, 3 insertions, 6 deletions
diff --git a/helix-term/src/ui/markdown.rs b/helix-term/src/ui/markdown.rs
index 923dd73a..87136992 100644
--- a/helix-term/src/ui/markdown.rs
+++ b/helix-term/src/ui/markdown.rs
@@ -342,13 +342,10 @@ impl Component for Markdown {
fn required_size(&mut self, viewport: (u16, u16)) -> Option<(u16, u16)> {
let padding = 2;
- if padding >= viewport.1 || padding >= viewport.0 {
- return None;
- }
let contents = self.parse(None);
// TODO: account for tab width
- let max_text_width = (viewport.0 - padding).min(120);
+ let max_text_width = (viewport.0.saturating_sub(padding)).min(120);
let (width, height) = crate::ui::text::required_size(&contents, max_text_width);
Some((width + padding, height + padding))
diff --git a/helix-view/src/graphics.rs b/helix-view/src/graphics.rs
index a0b645fa..e813fb56 100644
--- a/helix-view/src/graphics.rs
+++ b/helix-view/src/graphics.rs
@@ -237,8 +237,8 @@ impl Rect {
Rect {
x: x1,
y: y1,
- width: x2 - x1,
- height: y2 - y1,
+ width: x2.saturating_sub(x1),
+ height: y2.saturating_sub(y1),
}
}