Unnamed repository; edit this file 'description' to name the repository.
Remove inline `rust_2018_idioms, unused_lifetimes` lint warn, Cargo.toml already enforces this
Lukas Wirth 2024-06-30
parent e926469 · commit 21a3d01
-rw-r--r--crates/base-db/src/lib.rs2
-rw-r--r--crates/cfg/src/lib.rs2
-rw-r--r--crates/flycheck/src/lib.rs2
-rw-r--r--crates/hir-def/src/lib.rs1
-rw-r--r--crates/hir-expand/src/lib.rs1
-rw-r--r--crates/hir-ty/src/lib.rs2
-rw-r--r--crates/hir/src/lib.rs1
-rw-r--r--crates/ide-assists/src/lib.rs2
-rw-r--r--crates/ide-completion/src/lib.rs2
-rw-r--r--crates/ide-db/src/lib.rs2
-rw-r--r--crates/ide-diagnostics/src/lib.rs2
-rw-r--r--crates/ide-ssr/src/lib.rs2
-rw-r--r--crates/ide/src/lib.rs2
-rw-r--r--crates/limit/src/lib.rs2
-rw-r--r--crates/mbe/src/lib.rs2
-rw-r--r--crates/parser/src/lib.rs1
-rw-r--r--crates/paths/src/lib.rs2
-rw-r--r--crates/proc-macro-api/src/lib.rs2
-rw-r--r--crates/proc-macro-srv/proc-macro-test/imp/src/lib.rs2
-rw-r--r--crates/proc-macro-srv/proc-macro-test/src/lib.rs2
-rw-r--r--crates/proc-macro-srv/src/lib.rs1
-rw-r--r--crates/profile/src/lib.rs2
-rw-r--r--crates/project-model/src/lib.rs2
-rw-r--r--crates/rust-analyzer/src/bin/main.rs1
-rw-r--r--crates/rust-analyzer/src/lib.rs2
-rw-r--r--crates/rust-analyzer/tests/slow-tests/main.rs1
-rw-r--r--crates/sourcegen/src/lib.rs2
-rw-r--r--crates/stdx/src/lib.rs2
-rw-r--r--crates/syntax/src/lib.rs1
-rw-r--r--crates/test-utils/src/lib.rs1
-rw-r--r--crates/text-edit/src/lib.rs2
-rw-r--r--crates/toolchain/src/lib.rs2
-rw-r--r--crates/tt/src/lib.rs2
-rw-r--r--crates/vfs-notify/src/lib.rs2
-rw-r--r--crates/vfs/src/lib.rs2
35 files changed, 3 insertions, 58 deletions
diff --git a/crates/base-db/src/lib.rs b/crates/base-db/src/lib.rs
index f5165ea8a7..96fbbc317d 100644
--- a/crates/base-db/src/lib.rs
+++ b/crates/base-db/src/lib.rs
@@ -1,7 +1,5 @@
//! base_db defines basic database traits. The concrete DB is defined by ide.
-#![warn(rust_2018_idioms, unused_lifetimes)]
-
mod change;
mod input;
diff --git a/crates/cfg/src/lib.rs b/crates/cfg/src/lib.rs
index 9a365889e6..8b30286a0a 100644
--- a/crates/cfg/src/lib.rs
+++ b/crates/cfg/src/lib.rs
@@ -1,7 +1,5 @@
//! cfg defines conditional compiling options, `cfg` attribute parser and evaluator
-#![warn(rust_2018_idioms, unused_lifetimes)]
-
mod cfg_expr;
mod dnf;
#[cfg(test)]
diff --git a/crates/flycheck/src/lib.rs b/crates/flycheck/src/lib.rs
index 4584400e66..a257633516 100644
--- a/crates/flycheck/src/lib.rs
+++ b/crates/flycheck/src/lib.rs
@@ -6,8 +6,6 @@
// addition to `cargo check`. Either split it into 3 crates (one for test, one for check
// and one common utilities) or change its name and docs to reflect the current state.
-#![warn(rust_2018_idioms, unused_lifetimes)]
-
use std::{fmt, io, process::Command, time::Duration};
use crossbeam_channel::{never, select, unbounded, Receiver, Sender};
diff --git a/crates/hir-def/src/lib.rs b/crates/hir-def/src/lib.rs
index 3fa98efbb5..211cdd35fd 100644
--- a/crates/hir-def/src/lib.rs
+++ b/crates/hir-def/src/lib.rs
@@ -7,7 +7,6 @@
//! Note that `hir_def` is a work in progress, so not all of the above is
//! actually true.
-#![warn(rust_2018_idioms, unused_lifetimes)]
#![cfg_attr(feature = "in-rust-tree", feature(rustc_private))]
#[cfg(feature = "in-rust-tree")]
diff --git a/crates/hir-expand/src/lib.rs b/crates/hir-expand/src/lib.rs
index a7150cf308..e7c34e51e8 100644
--- a/crates/hir-expand/src/lib.rs
+++ b/crates/hir-expand/src/lib.rs
@@ -4,7 +4,6 @@
//! tree originates not from the text of some `FileId`, but from some macro
//! expansion.
#![cfg_attr(feature = "in-rust-tree", feature(rustc_private))]
-#![warn(rust_2018_idioms, unused_lifetimes)]
pub mod attrs;
pub mod builtin_attr_macro;
diff --git a/crates/hir-ty/src/lib.rs b/crates/hir-ty/src/lib.rs
index 07c0cf920f..bd650869bb 100644
--- a/crates/hir-ty/src/lib.rs
+++ b/crates/hir-ty/src/lib.rs
@@ -1,6 +1,6 @@
//! The type system. We currently use this to infer types for completion, hover
//! information and various assists.
-#![warn(rust_2018_idioms, unused_lifetimes)]
+
#![cfg_attr(feature = "in-rust-tree", feature(rustc_private))]
#[cfg(feature = "in-rust-tree")]
diff --git a/crates/hir/src/lib.rs b/crates/hir/src/lib.rs
index eea25ac18a..a9ae8d5649 100644
--- a/crates/hir/src/lib.rs
+++ b/crates/hir/src/lib.rs
@@ -17,7 +17,6 @@
//! from the ide with completions, hovers, etc. It is a (soft, internal) boundary:
//! <https://www.tedinski.com/2018/02/06/system-boundaries.html>.
-#![warn(rust_2018_idioms, unused_lifetimes)]
#![cfg_attr(feature = "in-rust-tree", feature(rustc_private))]
#![recursion_limit = "512"]
diff --git a/crates/ide-assists/src/lib.rs b/crates/ide-assists/src/lib.rs
index abebdec1d1..685d230dc6 100644
--- a/crates/ide-assists/src/lib.rs
+++ b/crates/ide-assists/src/lib.rs
@@ -58,8 +58,6 @@
//! See also this post:
//! <https://rust-analyzer.github.io/blog/2020/09/28/how-to-make-a-light-bulb.html>
-#![warn(rust_2018_idioms, unused_lifetimes)]
-
mod assist_config;
mod assist_context;
#[cfg(test)]
diff --git a/crates/ide-completion/src/lib.rs b/crates/ide-completion/src/lib.rs
index 8323b8f933..7150fe3f01 100644
--- a/crates/ide-completion/src/lib.rs
+++ b/crates/ide-completion/src/lib.rs
@@ -1,7 +1,5 @@
//! `completions` crate provides utilities for generating completions of user input.
-#![warn(rust_2018_idioms, unused_lifetimes)]
-
mod completions;
mod config;
mod context;
diff --git a/crates/ide-db/src/lib.rs b/crates/ide-db/src/lib.rs
index 357209ceb0..8fac5baa57 100644
--- a/crates/ide-db/src/lib.rs
+++ b/crates/ide-db/src/lib.rs
@@ -2,8 +2,6 @@
//!
//! It is mainly a `HirDatabase` for semantic analysis, plus a `SymbolsDatabase`, for fuzzy search.
-#![warn(rust_2018_idioms, unused_lifetimes)]
-
mod apply_change;
pub mod active_parameter;
diff --git a/crates/ide-diagnostics/src/lib.rs b/crates/ide-diagnostics/src/lib.rs
index a419f04bfa..c696faf270 100644
--- a/crates/ide-diagnostics/src/lib.rs
+++ b/crates/ide-diagnostics/src/lib.rs
@@ -23,8 +23,6 @@
//! There are also a couple of ad-hoc diagnostics implemented directly here, we
//! don't yet have a great pattern for how to do them properly.
-#![warn(rust_2018_idioms, unused_lifetimes)]
-
mod handlers {
pub(crate) mod break_outside_of_loop;
pub(crate) mod expected_function;
diff --git a/crates/ide-ssr/src/lib.rs b/crates/ide-ssr/src/lib.rs
index b5bf510aee..407433ed19 100644
--- a/crates/ide-ssr/src/lib.rs
+++ b/crates/ide-ssr/src/lib.rs
@@ -3,8 +3,6 @@
//! Allows searching the AST for code that matches one or more patterns and then replacing that code
//! based on a template.
-#![warn(rust_2018_idioms, unused_lifetimes)]
-
// Feature: Structural Search and Replace
//
// Search and replace with named wildcards that will match any expression, type, path, pattern or item.
diff --git a/crates/ide/src/lib.rs b/crates/ide/src/lib.rs
index a2ac62341d..28ae0dce98 100644
--- a/crates/ide/src/lib.rs
+++ b/crates/ide/src/lib.rs
@@ -8,7 +8,7 @@
//! in this crate.
// For proving that RootDatabase is RefUnwindSafe.
-#![warn(rust_2018_idioms, unused_lifetimes)]
+
#![cfg_attr(feature = "in-rust-tree", feature(rustc_private))]
#![recursion_limit = "128"]
diff --git a/crates/limit/src/lib.rs b/crates/limit/src/lib.rs
index 27471db6a3..c1caeed2f8 100644
--- a/crates/limit/src/lib.rs
+++ b/crates/limit/src/lib.rs
@@ -1,7 +1,5 @@
//! limit defines a struct to enforce limits.
-#![warn(rust_2018_idioms, unused_lifetimes)]
-
#[cfg(feature = "tracking")]
use std::sync::atomic::AtomicUsize;
diff --git a/crates/mbe/src/lib.rs b/crates/mbe/src/lib.rs
index 5f0598dfe0..b2fd91f6ce 100644
--- a/crates/mbe/src/lib.rs
+++ b/crates/mbe/src/lib.rs
@@ -6,8 +6,6 @@
//! The tests for this functionality live in another crate:
//! `hir_def::macro_expansion_tests::mbe`.
-#![warn(rust_2018_idioms, unused_lifetimes)]
-
mod expander;
mod parser;
mod syntax_bridge;
diff --git a/crates/parser/src/lib.rs b/crates/parser/src/lib.rs
index c2f9ea4772..738ed239a7 100644
--- a/crates/parser/src/lib.rs
+++ b/crates/parser/src/lib.rs
@@ -17,7 +17,6 @@
//!
//! [`Parser`]: crate::parser::Parser
-#![warn(rust_2018_idioms, unused_lifetimes)]
#![allow(rustdoc::private_intra_doc_links)]
#![cfg_attr(feature = "in-rust-tree", feature(rustc_private))]
diff --git a/crates/paths/src/lib.rs b/crates/paths/src/lib.rs
index 33c3f83db5..885f071889 100644
--- a/crates/paths/src/lib.rs
+++ b/crates/paths/src/lib.rs
@@ -1,8 +1,6 @@
//! Thin wrappers around `std::path`/`camino::path`, distinguishing between absolute and
//! relative paths.
-#![warn(rust_2018_idioms, unused_lifetimes)]
-
use std::{
borrow::Borrow,
ffi::OsStr,
diff --git a/crates/proc-macro-api/src/lib.rs b/crates/proc-macro-api/src/lib.rs
index c64ec77487..039509d87c 100644
--- a/crates/proc-macro-api/src/lib.rs
+++ b/crates/proc-macro-api/src/lib.rs
@@ -5,8 +5,6 @@
//! is used to provide basic infrastructure for communication between two
//! processes: Client (RA itself), Server (the external program)
-#![warn(rust_2018_idioms, unused_lifetimes)]
-
pub mod msg;
mod process;
diff --git a/crates/proc-macro-srv/proc-macro-test/imp/src/lib.rs b/crates/proc-macro-srv/proc-macro-test/imp/src/lib.rs
index 5f8530d08c..a1707364f3 100644
--- a/crates/proc-macro-srv/proc-macro-test/imp/src/lib.rs
+++ b/crates/proc-macro-srv/proc-macro-test/imp/src/lib.rs
@@ -1,6 +1,6 @@
//! Exports a few trivial procedural macros for testing.
-#![warn(rust_2018_idioms, unused_lifetimes)]
+
#![feature(proc_macro_span, proc_macro_def_site)]
#![allow(clippy::all)]
diff --git a/crates/proc-macro-srv/proc-macro-test/src/lib.rs b/crates/proc-macro-srv/proc-macro-test/src/lib.rs
index 739c6ec6f4..2edf23a634 100644
--- a/crates/proc-macro-srv/proc-macro-test/src/lib.rs
+++ b/crates/proc-macro-srv/proc-macro-test/src/lib.rs
@@ -1,6 +1,4 @@
//! Exports a few trivial procedural macros for testing.
-#![warn(rust_2018_idioms, unused_lifetimes)]
-
pub static PROC_MACRO_TEST_LOCATION: &str =
include_str!(concat!(env!("OUT_DIR"), "/proc_macro_test_location.txt"));
diff --git a/crates/proc-macro-srv/src/lib.rs b/crates/proc-macro-srv/src/lib.rs
index 2472c1e311..b86dceeb50 100644
--- a/crates/proc-macro-srv/src/lib.rs
+++ b/crates/proc-macro-srv/src/lib.rs
@@ -13,7 +13,6 @@
#![cfg(any(feature = "sysroot-abi", rust_analyzer))]
#![cfg_attr(feature = "in-rust-tree", feature(rustc_private))]
#![feature(proc_macro_internals, proc_macro_diagnostic, proc_macro_span)]
-#![warn(rust_2018_idioms, unused_lifetimes)]
#![allow(unreachable_pub, internal_features)]
extern crate proc_macro;
diff --git a/crates/profile/src/lib.rs b/crates/profile/src/lib.rs
index 2ccb1cd06a..c1ae0d43d0 100644
--- a/crates/profile/src/lib.rs
+++ b/crates/profile/src/lib.rs
@@ -1,7 +1,5 @@
//! A collection of tools for profiling rust-analyzer.
-#![warn(rust_2018_idioms, unused_lifetimes)]
-
#[cfg(feature = "cpu_profiler")]
mod google_cpu_profiler;
mod memory_usage;
diff --git a/crates/project-model/src/lib.rs b/crates/project-model/src/lib.rs
index 35643dcc02..92bf6a08f8 100644
--- a/crates/project-model/src/lib.rs
+++ b/crates/project-model/src/lib.rs
@@ -15,8 +15,6 @@
//! procedural macros).
//! * Lowering of concrete model to a [`base_db::CrateGraph`]
-#![warn(rust_2018_idioms, unused_lifetimes)]
-
mod build_scripts;
mod cargo_workspace;
mod cfg;
diff --git a/crates/rust-analyzer/src/bin/main.rs b/crates/rust-analyzer/src/bin/main.rs
index 774784f37b..1985093bc5 100644
--- a/crates/rust-analyzer/src/bin/main.rs
+++ b/crates/rust-analyzer/src/bin/main.rs
@@ -2,7 +2,6 @@
//!
//! Based on cli flags, either spawns an LSP server, or runs a batch analysis
-#![warn(rust_2018_idioms, unused_lifetimes)]
#![allow(clippy::print_stdout, clippy::print_stderr)]
#![cfg_attr(feature = "in-rust-tree", feature(rustc_private))]
diff --git a/crates/rust-analyzer/src/lib.rs b/crates/rust-analyzer/src/lib.rs
index a398e98f09..a8e6657c24 100644
--- a/crates/rust-analyzer/src/lib.rs
+++ b/crates/rust-analyzer/src/lib.rs
@@ -9,8 +9,6 @@
//! The `cli` submodule implements some batch-processing analysis, primarily as
//! a debugging aid.
-#![warn(rust_2018_idioms, unused_lifetimes)]
-
pub mod cli;
mod caps;
diff --git a/crates/rust-analyzer/tests/slow-tests/main.rs b/crates/rust-analyzer/tests/slow-tests/main.rs
index f886df60e6..51b3076b46 100644
--- a/crates/rust-analyzer/tests/slow-tests/main.rs
+++ b/crates/rust-analyzer/tests/slow-tests/main.rs
@@ -8,7 +8,6 @@
//! specific JSON shapes here -- there's little value in such tests, as we can't
//! be sure without a real client anyway.
-#![warn(rust_2018_idioms, unused_lifetimes)]
#![allow(clippy::disallowed_types)]
mod ratoml;
diff --git a/crates/sourcegen/src/lib.rs b/crates/sourcegen/src/lib.rs
index 829b4d5b0f..307c214c61 100644
--- a/crates/sourcegen/src/lib.rs
+++ b/crates/sourcegen/src/lib.rs
@@ -6,8 +6,6 @@
//!
//! This crate contains utilities to make this kind of source-gen easy.
-#![warn(rust_2018_idioms, unused_lifetimes)]
-
use std::{
fmt, fs, mem,
path::{Path, PathBuf},
diff --git a/crates/stdx/src/lib.rs b/crates/stdx/src/lib.rs
index 54f10df42a..76dbd42ff6 100644
--- a/crates/stdx/src/lib.rs
+++ b/crates/stdx/src/lib.rs
@@ -1,7 +1,5 @@
//! Missing batteries for standard libraries.
-#![warn(rust_2018_idioms, unused_lifetimes)]
-
use std::io as sio;
use std::process::Command;
use std::{cmp::Ordering, ops, time::Instant};
diff --git a/crates/syntax/src/lib.rs b/crates/syntax/src/lib.rs
index b5d816b0ce..177f48b986 100644
--- a/crates/syntax/src/lib.rs
+++ b/crates/syntax/src/lib.rs
@@ -20,7 +20,6 @@
//! [Swift]: <https://github.com/apple/swift/blob/13d593df6f359d0cb2fc81cfaac273297c539455/lib/Syntax/README.md>
#![cfg_attr(feature = "in-rust-tree", feature(rustc_private))]
-#![warn(rust_2018_idioms, unused_lifetimes)]
#[cfg(not(feature = "in-rust-tree"))]
extern crate ra_ap_rustc_lexer as rustc_lexer;
diff --git a/crates/test-utils/src/lib.rs b/crates/test-utils/src/lib.rs
index 53d4a28bc3..088817b835 100644
--- a/crates/test-utils/src/lib.rs
+++ b/crates/test-utils/src/lib.rs
@@ -6,7 +6,6 @@
//! * Extracting markup (mainly, `$0` markers) out of fixture strings.
//! * marks (see the eponymous module).
-#![warn(rust_2018_idioms, unused_lifetimes)]
#![allow(clippy::print_stderr)]
mod assert_linear;
diff --git a/crates/text-edit/src/lib.rs b/crates/text-edit/src/lib.rs
index e2ff373c1b..3efe0850d8 100644
--- a/crates/text-edit/src/lib.rs
+++ b/crates/text-edit/src/lib.rs
@@ -4,8 +4,6 @@
//! so `TextEdit` is the ultimate representation of the work done by
//! rust-analyzer.
-#![warn(rust_2018_idioms, unused_lifetimes)]
-
use itertools::Itertools;
use std::cmp::max;
pub use text_size::{TextRange, TextSize};
diff --git a/crates/toolchain/src/lib.rs b/crates/toolchain/src/lib.rs
index 2591ed1691..a0603e35a0 100644
--- a/crates/toolchain/src/lib.rs
+++ b/crates/toolchain/src/lib.rs
@@ -1,7 +1,5 @@
//! Discovery of `cargo` & `rustc` executables.
-#![warn(rust_2018_idioms, unused_lifetimes)]
-
use std::{env, iter, path::PathBuf};
use camino::{Utf8Path, Utf8PathBuf};
diff --git a/crates/tt/src/lib.rs b/crates/tt/src/lib.rs
index b2a21b1913..369744d0e9 100644
--- a/crates/tt/src/lib.rs
+++ b/crates/tt/src/lib.rs
@@ -2,8 +2,6 @@
//! input and output) of macros. It closely mirrors `proc_macro` crate's
//! `TokenTree`.
-#![warn(rust_2018_idioms, unused_lifetimes)]
-
pub mod buffer;
pub mod iter;
diff --git a/crates/vfs-notify/src/lib.rs b/crates/vfs-notify/src/lib.rs
index 1dbccab370..7e0f9af7af 100644
--- a/crates/vfs-notify/src/lib.rs
+++ b/crates/vfs-notify/src/lib.rs
@@ -7,8 +7,6 @@
//! Hopefully, one day a reliable file watching/walking crate appears on
//! crates.io, and we can reduce this to trivial glue code.
-#![warn(rust_2018_idioms, unused_lifetimes)]
-
use std::{
fs,
path::{Component, Path},
diff --git a/crates/vfs/src/lib.rs b/crates/vfs/src/lib.rs
index 18c8699dd4..b3aa6e2fe1 100644
--- a/crates/vfs/src/lib.rs
+++ b/crates/vfs/src/lib.rs
@@ -38,8 +38,6 @@
//! [`Handle`]: loader::Handle
//! [`Entries`]: loader::Entry
-#![warn(rust_2018_idioms, unused_lifetimes)]
-
mod anchored_path;
pub mod file_set;
pub mod loader;