Unnamed repository; edit this file 'description' to name the repository.
Pass server extraEnv to isValidExecutable
Lukas Wirth 2023-08-12
parent 1b67823 · commit 33f9250
-rw-r--r--editors/code/src/bootstrap.ts2
-rw-r--r--editors/code/src/util.ts8
2 files changed, 7 insertions, 3 deletions
diff --git a/editors/code/src/bootstrap.ts b/editors/code/src/bootstrap.ts
index ef4dff095c..6cf399599d 100644
--- a/editors/code/src/bootstrap.ts
+++ b/editors/code/src/bootstrap.ts
@@ -20,7 +20,7 @@ export async function bootstrap(
log.info("Using server binary at", path);
- if (!isValidExecutable(path)) {
+ if (!isValidExecutable(path, config.serverExtraEnv)) {
if (config.serverPath) {
throw new Error(`Failed to execute ${path} --version. \`config.server.path\` or \`config.serverPath\` has been set explicitly.\
Consider removing this config or making a valid server binary available at that path.`);
diff --git a/editors/code/src/util.ts b/editors/code/src/util.ts
index 38ce676157..e539452577 100644
--- a/editors/code/src/util.ts
+++ b/editors/code/src/util.ts
@@ -2,6 +2,7 @@ import * as vscode from "vscode";
import { strict as nativeAssert } from "assert";
import { exec, type ExecOptions, spawnSync } from "child_process";
import { inspect } from "util";
+import { Env } from "./client";
export function assert(condition: boolean, explanation: string): asserts condition {
try {
@@ -93,10 +94,13 @@ export function isDocumentInWorkspace(document: RustDocument): boolean {
return false;
}
-export function isValidExecutable(path: string): boolean {
+export function isValidExecutable(path: string, extraEnv: Env): boolean {
log.debug("Checking availability of a binary at", path);
- const res = spawnSync(path, ["--version"], { encoding: "utf8" });
+ const res = spawnSync(path, ["--version"], {
+ encoding: "utf8",
+ env: { ...process.env, ...extraEnv },
+ });
const printOutput = res.error ? log.warn : log.info;
printOutput(path, "--version:", res);