Unnamed repository; edit this file 'description' to name the repository.
a few clippy fixes
| -rw-r--r-- | crates/cfg/src/lib.rs | 4 | ||||
| -rw-r--r-- | crates/flycheck/src/lib.rs | 2 | ||||
| -rw-r--r-- | crates/ide/src/goto_declaration.rs | 2 | ||||
| -rw-r--r-- | crates/ide/src/syntax_highlighting/highlight.rs | 2 | ||||
| -rw-r--r-- | crates/syntax/test_data/parser/fuzz-failures/0000.rs | 4 |
5 files changed, 9 insertions, 5 deletions
diff --git a/crates/cfg/src/lib.rs b/crates/cfg/src/lib.rs index 6ba056f308..417ba60919 100644 --- a/crates/cfg/src/lib.rs +++ b/crates/cfg/src/lib.rs @@ -113,6 +113,10 @@ impl CfgDiff { pub fn len(&self) -> usize { self.enable.len() + self.disable.len() } + + pub fn is_empty(&self) -> bool { + self.len() == 0 + } } impl fmt::Display for CfgDiff { diff --git a/crates/flycheck/src/lib.rs b/crates/flycheck/src/lib.rs index 34996280ca..1641f744cd 100644 --- a/crates/flycheck/src/lib.rs +++ b/crates/flycheck/src/lib.rs @@ -297,7 +297,7 @@ impl CargoActor { read_at_least_one_message = true; // Try to deserialize a message from Cargo or Rustc. - let mut deserializer = serde_json::Deserializer::from_str(&line); + let mut deserializer = serde_json::Deserializer::from_str(line); deserializer.disable_recursion_limit(); if let Ok(message) = JsonMessage::deserialize(&mut deserializer) { match message { diff --git a/crates/ide/src/goto_declaration.rs b/crates/ide/src/goto_declaration.rs index 7aef463032..2c5a24b1d2 100644 --- a/crates/ide/src/goto_declaration.rs +++ b/crates/ide/src/goto_declaration.rs @@ -57,7 +57,7 @@ mod tests { .unwrap() .expect("no declaration or definition found") .info; - if navs.len() == 0 { + if navs.is_empty() { panic!("unresolved reference") } diff --git a/crates/ide/src/syntax_highlighting/highlight.rs b/crates/ide/src/syntax_highlighting/highlight.rs index d2ec3ca939..47c0f00c00 100644 --- a/crates/ide/src/syntax_highlighting/highlight.rs +++ b/crates/ide/src/syntax_highlighting/highlight.rs @@ -741,7 +741,7 @@ fn parents_match(mut node: NodeOrToken<SyntaxNode, SyntaxToken>, mut kinds: &[Sy } // Only true if we matched all expected kinds - kinds.len() == 0 + kinds.is_empty() } #[inline] diff --git a/crates/syntax/test_data/parser/fuzz-failures/0000.rs b/crates/syntax/test_data/parser/fuzz-failures/0000.rs index f1d0dc3438..f977d23c48 100644 --- a/crates/syntax/test_data/parser/fuzz-failures/0000.rs +++ b/crates/syntax/test_data/parser/fuzz-failures/0000.rs @@ -101,7 +101,7 @@ pub /*(meh)*/ fn replace_range(mut text: String, range: TextRange, replace_with: } fn is_balanced(tokens: &[Token]) -> bool { - if tokens.len() == 0 + if tokens.is_empty() || tokens.first().unwrap().kind != L_CURLY || tokens.last().unwrap().kind != R_CURLY { return false @@ -153,7 +153,7 @@ pub /*(meh)*/ fn replace_range(mut text: String, range: TextRange, replace_with: } fn is_balanced(tokens: &[Token]) -> bool { - if tokens.len() == 0 + if tokens.is_empty() || tokens.first().unwrap().kind != L_CURLY || tokens.last().unwrap().kind != R_CURLY { return false |