Unnamed repository; edit this file 'description' to name the repository.
Add comments for why skip highlighting for invalid char/byte literals
| -rw-r--r-- | crates/ide/src/syntax_highlighting/escape.rs | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/crates/ide/src/syntax_highlighting/escape.rs b/crates/ide/src/syntax_highlighting/escape.rs index 41b27683f6..5913ca5e45 100644 --- a/crates/ide/src/syntax_highlighting/escape.rs +++ b/crates/ide/src/syntax_highlighting/escape.rs @@ -26,6 +26,9 @@ pub(super) fn highlight_escape_string<T: IsString>( pub(super) fn highlight_escape_char(stack: &mut Highlights, char: &Char, start: TextSize) { if char.value().is_none() { + // We do not emit invalid escapes highlighting here. The lexer would likely be in a bad + // state and this token contains junks, since `'` is not a reliable delimiter (consider + // lifetimes). Nonetheless, parser errors should already be emitted. return; } @@ -46,6 +49,7 @@ pub(super) fn highlight_escape_char(stack: &mut Highlights, char: &Char, start: pub(super) fn highlight_escape_byte(stack: &mut Highlights, byte: &Byte, start: TextSize) { if byte.value().is_none() { + // See `highlight_escape_char` for why no error highlighting here. return; } |