Unnamed repository; edit this file 'description' to name the repository.
Auto merge of #17000 - mrnossiom:master, r=Veykril
fix: set the right postfix snippets competion source range
Hi :wave:,
Changed the completion item `source_range` to match the replaced text. Though in VS Code it may not be disturbing because the snippet is previewed in a box, but in Helix editor, it's previewed by applying the main text edit.
Before :
After :
Thanks
| -rw-r--r-- | crates/ide-completion/src/completions/postfix.rs | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/crates/ide-completion/src/completions/postfix.rs b/crates/ide-completion/src/completions/postfix.rs index 361ad821f4..554f7e081e 100644 --- a/crates/ide-completion/src/completions/postfix.rs +++ b/crates/ide-completion/src/completions/postfix.rs @@ -333,8 +333,7 @@ fn build_postfix_snippet_builder<'ctx>( ) -> impl Fn(&str, &str, &str) -> Builder + 'ctx { move |label, detail, snippet| { let edit = TextEdit::replace(delete_range, snippet.to_owned()); - let mut item = - CompletionItem::new(CompletionItemKind::Snippet, ctx.source_range(), label); + let mut item = CompletionItem::new(CompletionItemKind::Snippet, delete_range, label); item.detail(detail).snippet_edit(cap, edit); let postfix_match = if ctx.original_token.text() == label { cov_mark::hit!(postfix_exact_match_is_high_priority); |