Unnamed repository; edit this file 'description' to name the repository.
Merge pull request #19166 from ChayimFriedman2/runnables-order
fix: Fix sorting of runnables
Laurențiu Nicola 2025-02-17
parent 2b485d7 · parent 353616b · commit 84b6936
-rw-r--r--crates/ide/src/annotations.rs9
-rw-r--r--crates/ide/src/runnables.rs6
2 files changed, 4 insertions, 11 deletions
diff --git a/crates/ide/src/annotations.rs b/crates/ide/src/annotations.rs
index a0add4741f..e47891bbdf 100644
--- a/crates/ide/src/annotations.rs
+++ b/crates/ide/src/annotations.rs
@@ -173,14 +173,7 @@ pub(crate) fn annotations(
annotations
.into_iter()
.sorted_by_key(|a| {
- (
- a.range.start(),
- a.range.end(),
- match &a.kind {
- AnnotationKind::Runnable(runnable) => Some(runnable.nav.name.clone()),
- _ => None,
- },
- )
+ (a.range.start(), a.range.end(), matches!(a.kind, AnnotationKind::Runnable(..)))
})
.collect()
}
diff --git a/crates/ide/src/runnables.rs b/crates/ide/src/runnables.rs
index 9e3b70fa8e..509ae3204c 100644
--- a/crates/ide/src/runnables.rs
+++ b/crates/ide/src/runnables.rs
@@ -61,8 +61,8 @@ pub enum RunnableKind {
#[derive(Debug, Clone, Hash, PartialEq, Eq, PartialOrd, Ord)]
enum RunnableDiscKind {
- Test,
TestMod,
+ Test,
DocTest,
Bench,
Bin,
@@ -1233,8 +1233,8 @@ gen_main!();
"(TestMod, NavigationTarget { file_id: FileId(0), full_range: 0..315, name: \"\", kind: Module })",
"(TestMod, NavigationTarget { file_id: FileId(0), full_range: 267..292, focus_range: 271..276, name: \"tests\", kind: Module, description: \"mod tests\" })",
"(Test, NavigationTarget { file_id: FileId(0), full_range: 283..290, name: \"foo_test\", kind: Function })",
- "(Test, NavigationTarget { file_id: FileId(0), full_range: 293..301, name: \"foo_test2\", kind: Function }, true)",
"(TestMod, NavigationTarget { file_id: FileId(0), full_range: 293..301, name: \"tests2\", kind: Module, description: \"mod tests2\" }, true)",
+ "(Test, NavigationTarget { file_id: FileId(0), full_range: 293..301, name: \"foo_test2\", kind: Function }, true)",
"(Bin, NavigationTarget { file_id: FileId(0), full_range: 302..314, name: \"main\", kind: Function })",
]
"#]],
@@ -1263,10 +1263,10 @@ foo!();
"#,
expect![[r#"
[
+ "(TestMod, NavigationTarget { file_id: FileId(0), full_range: 210..217, name: \"foo_tests\", kind: Module, description: \"mod foo_tests\" }, true)",
"(Test, NavigationTarget { file_id: FileId(0), full_range: 210..217, name: \"foo0\", kind: Function }, true)",
"(Test, NavigationTarget { file_id: FileId(0), full_range: 210..217, name: \"foo1\", kind: Function }, true)",
"(Test, NavigationTarget { file_id: FileId(0), full_range: 210..217, name: \"foo2\", kind: Function }, true)",
- "(TestMod, NavigationTarget { file_id: FileId(0), full_range: 210..217, name: \"foo_tests\", kind: Module, description: \"mod foo_tests\" }, true)",
]
"#]],
);