Unnamed repository; edit this file 'description' to name the repository.
Do not error for actions with no data to resolve
Same as the other resolve code handlers in the same file. https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#version_3_17_0 does not forbid resolving with no data, so instead of erroring, just consider such items resolved already.
Kirill Bulatov 2025-03-16
parent 220d913 · commit 9ac80de
-rw-r--r--crates/rust-analyzer/src/handlers/request.rs2
1 files changed, 1 insertions, 1 deletions
diff --git a/crates/rust-analyzer/src/handlers/request.rs b/crates/rust-analyzer/src/handlers/request.rs
index 170481ea70..5f27567c31 100644
--- a/crates/rust-analyzer/src/handlers/request.rs
+++ b/crates/rust-analyzer/src/handlers/request.rs
@@ -1480,7 +1480,7 @@ pub(crate) fn handle_code_action_resolve(
) -> anyhow::Result<lsp_ext::CodeAction> {
let _p = tracing::info_span!("handle_code_action_resolve").entered();
let Some(params) = code_action.data.take() else {
- return Err(invalid_params_error("code action without data".to_owned()).into());
+ return Ok(code_action);
};
let file_id = from_proto::file_id(&snap, &params.code_action_params.text_document.uri)?