bendns' repos / rust-analyzer
Unnamed repository; edit this file 'description' to name the repository.
Remove the toggleInlayHints command from VSCode
Inlay hints are no longer something specifc to r-a as it has been upstreamed into the LSP, we don't have a reason to give the config for this feature special treatment in regards to toggling. There are plenty of other options out there in the VSCode marketplace to create toggle commands/hotkeys for configurations in general which I believe we should nudge people towards instead.
Browse Source
Lukas Wirth 2022-09-10
parent 6909556 · commit 9c97997
Diffstat
-rw-r--r--editors/code/package.json9
-rw-r--r--editors/code/src/commands.ts24
-rw-r--r--editors/code/src/main.ts1
3 files changed, 0 insertions, 34 deletions
diff --git a/editors/code/package.json b/editors/code/package.json
index 767c5875bf..023b450209 100644
--- a/editors/code/package.json
+++ b/editors/code/package.json
@@ -207,11 +207,6 @@
"category": "rust-analyzer"
},
{
- "command": "rust-analyzer.toggleInlayHints",
- "title": "Toggle inlay hints",
- "category": "rust-analyzer"
- },
- {
"command": "rust-analyzer.openDocs",
"title": "Open docs under cursor",
"category": "rust-analyzer"
@@ -1634,10 +1629,6 @@
"when": "inRustProject"
},
{
- "command": "rust-analyzer.toggleInlayHints",
- "when": "inRustProject"
- },
- {
"command": "rust-analyzer.openDocs",
"when": "inRustProject"
},
diff --git a/editors/code/src/commands.ts b/editors/code/src/commands.ts
index a21b304bbd..b9ad525e36 100644
--- a/editors/code/src/commands.ts
+++ b/editors/code/src/commands.ts
@@ -321,30 +321,6 @@ export function serverVersion(ctx: Ctx): Cmd {
};
}
-export function toggleInlayHints(_ctx: Ctx): Cmd {
- return async () => {
- const config = vscode.workspace.getConfiguration("editor.inlayHints", {
- languageId: "rust",
- });
-
- const value = config.get("enabled");
- let stringValue;
- if (typeof value === "string") {
- stringValue = value;
- } else {
- stringValue = value ? "on" : "off";
- }
- const nextValues: Record<string, string> = {
- on: "off",
- off: "on",
- onUnlessPressed: "offUnlessPressed",
- offUnlessPressed: "onUnlessPressed",
- };
- const nextValue = nextValues[stringValue] ?? "on";
- await config.update("enabled", nextValue, vscode.ConfigurationTarget.Global);
- };
-}
-
// Opens the virtual file that will show the syntax tree
//
// The contents of the file come from the `TextDocumentContentProvider`
diff --git a/editors/code/src/main.ts b/editors/code/src/main.ts
index e9b62e0cc2..41bde4195e 100644
--- a/editors/code/src/main.ts
+++ b/editors/code/src/main.ts
@@ -180,7 +180,6 @@ async function initCommonContext(context: vscode.ExtensionContext, ctx: Ctx) {
ctx.registerCommand("ssr", commands.ssr);
ctx.registerCommand("serverVersion", commands.serverVersion);
- ctx.registerCommand("toggleInlayHints", commands.toggleInlayHints);
// Internal commands which are invoked by the server.
ctx.registerCommand("runSingle", commands.runSingle);