Unnamed repository; edit this file 'description' to name the repository.
Auto merge of #12417 - jonas-schievink:pr-msg-style, r=jonas-schievink
minor: Update commit/PR style guide
What matters for the changelog is having PR title/description from the user's perspective, while commits can be internal.
| -rw-r--r-- | docs/dev/style.md | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/docs/dev/style.md b/docs/dev/style.md index 13da88044c..82b6c749e4 100644 --- a/docs/dev/style.md +++ b/docs/dev/style.md @@ -69,11 +69,11 @@ After you are happy with the state of the code, please use [interactive rebase]( Avoid @mentioning people in commit messages and pull request descriptions(they are added to commit message by bors). Such messages create a lot of duplicate notification traffic during rebases. -If possible, write commit messages from user's perspective: +If possible, write Pull Request titles and descriptions from the user's perspective: ``` # GOOD -Goto definition works inside macros +Make goto definition work inside macros # BAD Use original span for FileId |