Unnamed repository; edit this file 'description' to name the repository.
Allow flycheck process to exit gracefully
Assuming it isn't cancelled. Closes #17902. The only place CommandHandle::join is used is when the flycheck command finishes, so this commit changes the behavior of the method itself.
Tyler Mandry 2024-08-16
parent 91aa3f4 · commit da34676
-rw-r--r--crates/rust-analyzer/src/command.rs1
1 files changed, 0 insertions, 1 deletions
diff --git a/crates/rust-analyzer/src/command.rs b/crates/rust-analyzer/src/command.rs
index f1009eb466..b19a1b8d16 100644
--- a/crates/rust-analyzer/src/command.rs
+++ b/crates/rust-analyzer/src/command.rs
@@ -148,7 +148,6 @@ impl<T: ParseFromLine> CommandHandle<T> {
}
pub(crate) fn join(mut self) -> io::Result<()> {
- let _ = self.child.0.kill();
let exit_status = self.child.0.wait()?;
let (read_at_least_one_message, error) = self.thread.join()?;
if read_at_least_one_message || exit_status.success() {