Unnamed repository; edit this file 'description' to name the repository.
toplevel_ref_arg
Johann Hemmann 2024-02-01
parent 386d438 · commit daa2072
-rw-r--r--Cargo.toml1
-rw-r--r--crates/hir-def/src/import_map.rs4
-rw-r--r--crates/hir/src/lib.rs2
3 files changed, 3 insertions, 4 deletions
diff --git a/Cargo.toml b/Cargo.toml
index 099ac296e4..f49593db5f 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -180,7 +180,6 @@ non_canonical_clone_impl = "allow"
non_canonical_partial_ord_impl = "allow"
self_named_constructors = "allow"
too_many_arguments = "allow"
-toplevel_ref_arg = "allow"
type_complexity = "allow"
unnecessary_cast = "allow"
unnecessary_filter_map = "allow"
diff --git a/crates/hir-def/src/import_map.rs b/crates/hir-def/src/import_map.rs
index 66d9cf54da..5d096c7a5e 100644
--- a/crates/hir-def/src/import_map.rs
+++ b/crates/hir-def/src/import_map.rs
@@ -396,7 +396,7 @@ impl Query {
pub fn search_dependencies(
db: &dyn DefDatabase,
krate: CrateId,
- ref query: Query,
+ query: &Query,
) -> FxHashSet<ItemInNs> {
let _p = tracing::span!(tracing::Level::INFO, "search_dependencies", ?query).entered();
@@ -516,7 +516,7 @@ mod tests {
})
.expect("could not find crate");
- let actual = search_dependencies(db.upcast(), krate, query)
+ let actual = search_dependencies(db.upcast(), krate, &query)
.into_iter()
.filter_map(|dependency| {
let dependency_krate = dependency.krate(db.upcast())?;
diff --git a/crates/hir/src/lib.rs b/crates/hir/src/lib.rs
index 28decd4ce7..2c5474c5c8 100644
--- a/crates/hir/src/lib.rs
+++ b/crates/hir/src/lib.rs
@@ -236,7 +236,7 @@ impl Crate {
query: import_map::Query,
) -> impl Iterator<Item = Either<ModuleDef, Macro>> {
let _p = tracing::span!(tracing::Level::INFO, "query_external_importables");
- import_map::search_dependencies(db, self.into(), query).into_iter().map(|item| {
+ import_map::search_dependencies(db, self.into(), &query).into_iter().map(|item| {
match ItemInNs::from(item) {
ItemInNs::Types(mod_id) | ItemInNs::Values(mod_id) => Either::Left(mod_id),
ItemInNs::Macros(mac_id) => Either::Right(mac_id),