Unnamed repository; edit this file 'description' to name the repository.
Merge #10053
10053: Remove old workaround in vscode extension r=lnicola a=Azorlogh See #3167. Co-authored-by: = <[email protected]>
bors[bot] 2021-08-27
parent 8f683e9 · parent e3dd43c · commit 4ad0a1b
-rw-r--r--editors/code/src/net.ts15
1 files changed, 0 insertions, 15 deletions
diff --git a/editors/code/src/net.ts b/editors/code/src/net.ts
index b8defe92cd..fbd9434d90 100644
--- a/editors/code/src/net.ts
+++ b/editors/code/src/net.ts
@@ -200,19 +200,4 @@ async function downloadFile(
const srcStream = gunzip ? res.body.pipe(zlib.createGunzip()) : res.body;
await pipeline(srcStream, destFileStream);
-
- // Don't apply the workaround in fixed versions of nodejs, since the process
- // freezes on them, the process waits for no-longer emitted `close` event.
- // The fix was applied in commit 7eed9d6bcc in v13.11.0
- // See the nodejs changelog:
- // https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V13.md
- const [, major, minor] = /v(\d+)\.(\d+)\.(\d+)/.exec(process.version)!;
- if (+major > 13 || (+major === 13 && +minor >= 11)) return;
-
- await new Promise<void>(resolve => {
- destFileStream.on("close", resolve);
- destFileStream.destroy();
- // This workaround is awaiting to be removed when vscode moves to newer nodejs version:
- // https://github.com/rust-analyzer/rust-analyzer/issues/3167
- });
}