Unnamed repository; edit this file 'description' to name the repository.
feat(diagnostics): use default expression instead of todo! when missing fields
Signed-off-by: Benjamin Coenen <[email protected]>
Benjamin Coenen 2022-01-07
parent b60a29c · commit 8e0a05e
-rw-r--r--crates/rust-analyzer/src/config.rs4
-rw-r--r--docs/user/generated_config.adoc2
-rw-r--r--editors/code/package.json6
3 files changed, 6 insertions, 6 deletions
diff --git a/crates/rust-analyzer/src/config.rs b/crates/rust-analyzer/src/config.rs
index 6be889df67..449402da45 100644
--- a/crates/rust-analyzer/src/config.rs
+++ b/crates/rust-analyzer/src/config.rs
@@ -45,7 +45,7 @@ use crate::{
// parsing the old name.
config_data! {
struct ConfigData {
- /// How assists will fill missing elements in an expression.
+ /// Placeholder for missing expressions in assists.
assist_exprFillDefault: ExprFillDefaultDef = "\"todo\"",
/// How imports should be grouped into use statements.
assist_importGranularity |
@@ -1272,7 +1272,7 @@ fn field_props(field: &str, ty: &str, doc: &[&str], default: &str) -> serde_json
"type": "string",
"enum": ["todo", "default"],
"enumDescriptions": [
- "Fill missing expressions with the 'todo' macro",
+ "Fill missing expressions with the `todo` macro",
"Fill missing expressions with reasonable defaults, `new` or `default` constructors."
],
},
diff --git a/docs/user/generated_config.adoc b/docs/user/generated_config.adoc
index 28350374d1..179e81cd36 100644
--- a/docs/user/generated_config.adoc
+++ b/docs/user/generated_config.adoc
@@ -1,7 +1,7 @@
[[rust-analyzer.assist.exprFillDefault]]rust-analyzer.assist.exprFillDefault (default: `"todo"`)::
+
--
-How assists will fill missing elements in an expression.
+Placeholder for missing expressions in assists.
--
[[rust-analyzer.assist.importGranularity]]rust-analyzer.assist.importGranularity (default: `"crate"`)::
+
diff --git a/editors/code/package.json b/editors/code/package.json
index c81fd0b3d2..aaf5d49b71 100644
--- a/editors/code/package.json
+++ b/editors/code/package.json
@@ -379,7 +379,7 @@
},
"$generated-start": {},
"rust-analyzer.assist.exprFillDefault": {
- "markdownDescription": "How assists will fill missing elements in an expression.",
+ "markdownDescription": "Placeholder for missing expressions in assists.",
"default": "todo",
"type": "string",
"enum": [
@@ -387,7 +387,7 @@
"default"
],
"enumDescriptions": [
- "Fill missing expressions with the 'todo' macro",
+ "Fill missing expressions with the `todo` macro",
"Fill missing expressions with reasonable defaults, `new` or `default` constructors."
]
},
@@ -1507,4 +1507,4 @@
]
}
}
-} \ No newline at end of file
+}