Unnamed repository; edit this file 'description' to name the repository.
Merge #10798
10798: ide: show go to for function hover return type r=Veykril a=jhgg
I've found myself wanting this... adds to the hover quick go-to for a function's return type:
This is particularly useful when you are hovering over a function in a long chain, like:
```rust
foo.bar().b$0az().some_trait_fn();
```
where `baz`'s return type is not immediately obvious, but the chain is not long enough to trigger chain inlay hints...
i guess I could just select `foo.bar().baz()` too to get the types too...
Co-authored-by: Jake Heinz <[email protected]>
| -rw-r--r-- | crates/ide/src/hover.rs | 1 | ||||
| -rw-r--r-- | crates/ide/src/hover/tests.rs | 59 |
2 files changed, 32 insertions, 28 deletions
diff --git a/crates/ide/src/hover.rs b/crates/ide/src/hover.rs index f4fb52647e..2ebf46b564 100644 --- a/crates/ide/src/hover.rs +++ b/crates/ide/src/hover.rs @@ -314,6 +314,7 @@ fn goto_type_action_for_def(db: &RootDatabase, def: Definition) -> Option<HoverA Definition::Local(it) => it.ty(db), Definition::GenericParam(hir::GenericParam::ConstParam(it)) => it.ty(db), Definition::Field(field) => field.ty(db), + Definition::Function(function) => function.ret_type(db), _ => return None, }; diff --git a/crates/ide/src/hover/tests.rs b/crates/ide/src/hover/tests.rs index 91a4db33fb..3b415c54fb 100644 --- a/crates/ide/src/hover/tests.rs +++ b/crates/ide/src/hover/tests.rs @@ -1718,40 +1718,43 @@ fn test_hover_test_has_action() { fn foo_$0test() {} "#, expect![[r#" - [ - Reference( - FilePosition { + [ + Reference( + FilePosition { + file_id: FileId( + 0, + ), + offset: 11, + }, + ), + Runnable( + Runnable { + use_name_in_title: false, + nav: NavigationTarget { file_id: FileId( 0, ), - offset: 11, + full_range: 0..24, + focus_range: 11..19, + name: "foo_test", + kind: Function, }, - ), - Runnable( - Runnable { - use_name_in_title: false, - nav: NavigationTarget { - file_id: FileId( - 0, - ), - full_range: 0..24, - focus_range: 11..19, - name: "foo_test", - kind: Function, - }, - kind: Test { - test_id: Path( - "foo_test", - ), - attr: TestAttr { - ignore: false, - }, + kind: Test { + test_id: Path( + "foo_test", + ), + attr: TestAttr { + ignore: false, }, - cfg: None, }, - ), - ] - "#]], + cfg: None, + }, + ), + GoToType( + [], + ), + ] + "#]], ); } |