Use the target checking infrastructure for the diagnostic attributes The goal of this is a few things: * Make the diagnostic attributes' target checking cleaner and more declarative, making it harder to make mistakes here * Make progress towards removing the `ALL_TARGETS` list r? @mejrs