Unnamed repository; edit this file 'description' to name the repository.
Add some fixme comments
A4-Tacks 5 weeks ago
parent 3246e4b · commit 144cce8
-rw-r--r--crates/ide-assists/src/handlers/extract_variable.rs34
1 files changed, 34 insertions, 0 deletions
diff --git a/crates/ide-assists/src/handlers/extract_variable.rs b/crates/ide-assists/src/handlers/extract_variable.rs
index 728af87bc6..732bab4cec 100644
--- a/crates/ide-assists/src/handlers/extract_variable.rs
+++ b/crates/ide-assists/src/handlers/extract_variable.rs
@@ -2830,6 +2830,7 @@ fn main() {
#[test]
fn extract_variable_in_token_tree() {
+ // FIXME: Keep the original trivia instead of extracting macro expanded?
check_assist_by_label(
extract_variable,
r#"
@@ -2913,6 +2914,39 @@ fn main() {
"#,
"Extract into variable",
);
+
+ // FIXME: Extract to inside the macro instead of outside the macro
+ check_assist_by_label(
+ extract_variable,
+ r#"
+macro_rules! foo {
+ (= $($t:tt)*) => {
+ $($t)*
+ };
+}
+
+fn main() {
+ let x = foo!(= {
+ $02 + 3 + 4$0
+ });
+}
+"#,
+ r#"
+macro_rules! foo {
+ (= $($t:tt)*) => {
+ $($t)*
+ };
+}
+
+fn main() {
+ let $0var_name = 2+3+4;
+ let x = foo!(= {
+ var_name
+ });
+}
+"#,
+ "Extract into variable",
+ );
}
#[test]