Unnamed repository; edit this file 'description' to name the repository.
Diffstat (limited to 'crates/hir-ty/src/display.rs')
| -rw-r--r-- | crates/hir-ty/src/display.rs | 27 |
1 files changed, 12 insertions, 15 deletions
diff --git a/crates/hir-ty/src/display.rs b/crates/hir-ty/src/display.rs index 3a0ec6a582..750e159727 100644 --- a/crates/hir-ty/src/display.rs +++ b/crates/hir-ty/src/display.rs @@ -427,7 +427,7 @@ impl HirDisplay for Const { Ok(()) } ConstValue::Concrete(c) => match &c.interned { - ConstScalar::Bytes(b, m) => render_const_scalar(f, &b, m, &data.ty), + ConstScalar::Bytes(b, m) => render_const_scalar(f, b, m, &data.ty), ConstScalar::UnevaluatedConst(c, parameters) => { write!(f, "{}", c.name(f.db.upcast()))?; hir_fmt_generics(f, parameters, c.generic_def(f.db.upcast()))?; @@ -451,7 +451,7 @@ fn render_const_scalar( TraitEnvironment::empty(*f.db.crate_graph().crates_in_topological_order().last().unwrap()); match ty.kind(Interner) { TyKind::Scalar(s) => match s { - Scalar::Bool => write!(f, "{}", if b[0] == 0 { false } else { true }), + Scalar::Bool => write!(f, "{}", b[0] != 0), Scalar::Char => { let it = u128::from_le_bytes(pad16(b, false)) as u32; let Ok(c) = char::try_from(it) else { @@ -485,7 +485,7 @@ fn render_const_scalar( let Some(bytes) = memory_map.get(addr, size) else { return f.write_str("<ref-data-not-available>"); }; - let s = std::str::from_utf8(&bytes).unwrap_or("<utf8-error>"); + let s = std::str::from_utf8(bytes).unwrap_or("<utf8-error>"); write!(f, "{s:?}") } TyKind::Slice(ty) => { @@ -507,7 +507,7 @@ fn render_const_scalar( f.write_str(", ")?; } let offset = size_one * i; - render_const_scalar(f, &bytes[offset..offset + size_one], memory_map, &ty)?; + render_const_scalar(f, &bytes[offset..offset + size_one], memory_map, ty)?; } f.write_str("]") } @@ -533,9 +533,7 @@ fn render_const_scalar( write!(f, "&{}", data.name.display(f.db.upcast()))?; Ok(()) } - _ => { - return f.write_str("<unsized-enum-or-union>"); - } + _ => f.write_str("<unsized-enum-or-union>"), }, _ => { let addr = usize::from_le_bytes(match b.try_into() { @@ -579,7 +577,7 @@ fn render_const_scalar( continue; }; let size = layout.size.bytes_usize(); - render_const_scalar(f, &b[offset..offset + size], memory_map, &ty)?; + render_const_scalar(f, &b[offset..offset + size], memory_map, ty)?; } f.write_str(")") } @@ -620,7 +618,7 @@ fn render_const_scalar( f, &field_types, f.db.trait_environment(adt.0.into()), - &var_layout, + var_layout, subst, b, memory_map, @@ -651,7 +649,7 @@ fn render_const_scalar( f.write_str(", ")?; } let offset = size_one * i; - render_const_scalar(f, &b[offset..offset + size_one], memory_map, &ty)?; + render_const_scalar(f, &b[offset..offset + size_one], memory_map, ty)?; } f.write_str("]") } @@ -718,7 +716,7 @@ fn render_variant_after_name( } write!(f, ")")?; } - return Ok(()); + Ok(()) } VariantData::Unit => Ok(()), } @@ -864,7 +862,7 @@ impl HirDisplay for Ty { write!(f, ",)")?; } else { write!(f, "(")?; - f.write_joined(&*substs.as_slice(Interner), ", ")?; + f.write_joined(substs.as_slice(Interner), ", ")?; write!(f, ")")?; } } @@ -1210,8 +1208,7 @@ impl HirDisplay for Ty { let subst = subst.as_slice(Interner); let a: Option<SmallVec<[&Ty; 3]>> = subst .get(subst.len() - 3..) - .map(|args| args.iter().map(|arg| arg.ty(Interner)).collect()) - .flatten(); + .and_then(|args| args.iter().map(|arg| arg.ty(Interner)).collect()); if let Some([resume_ty, yield_ty, ret_ty]) = a.as_deref() { write!(f, "|")?; @@ -1422,7 +1419,7 @@ fn write_bounds_like_dyn_trait( f.start_location_link(trait_.into()); write!(f, "{}", f.db.trait_data(trait_).name.display(f.db.upcast()))?; f.end_location_link(); - if let [_, params @ ..] = &*trait_ref.substitution.as_slice(Interner) { + if let [_, params @ ..] = trait_ref.substitution.as_slice(Interner) { if is_fn_trait { if let Some(args) = params.first().and_then(|it| it.assert_ty_ref(Interner).as_tuple()) |