Unnamed repository; edit this file 'description' to name the repository.
Diffstat (limited to 'crates/ide-assists/src/handlers/convert_while_to_loop.rs')
-rw-r--r--crates/ide-assists/src/handlers/convert_while_to_loop.rs33
1 files changed, 18 insertions, 15 deletions
diff --git a/crates/ide-assists/src/handlers/convert_while_to_loop.rs b/crates/ide-assists/src/handlers/convert_while_to_loop.rs
index 9fd8b4b315..f8215d6723 100644
--- a/crates/ide-assists/src/handlers/convert_while_to_loop.rs
+++ b/crates/ide-assists/src/handlers/convert_while_to_loop.rs
@@ -6,7 +6,7 @@ use syntax::{
ast::{
self, HasLoopBody,
edit::{AstNodeEdit, IndentLevel},
- make,
+ syntax_factory::SyntaxFactory,
},
syntax_editor::{Element, Position},
};
@@ -14,7 +14,7 @@ use syntax::{
use crate::{
AssistId,
assist_context::{AssistContext, Assists},
- utils::invert_boolean_expression_legacy,
+ utils::invert_boolean_expression,
};
// Assist: convert_while_to_loop
@@ -52,44 +52,47 @@ pub(crate) fn convert_while_to_loop(acc: &mut Assists, ctx: &AssistContext<'_>)
"Convert while to loop",
target,
|builder| {
+ let make = SyntaxFactory::without_mappings();
let mut edit = builder.make_editor(while_expr.syntax());
let while_indent_level = IndentLevel::from_node(while_expr.syntax());
- let break_block = make::block_expr(
- iter::once(make::expr_stmt(make::expr_break(None, None)).into()),
- None,
- )
- .indent(IndentLevel(1));
+ let break_block = make
+ .block_expr(
+ iter::once(make.expr_stmt(make.expr_break(None, None).into()).into()),
+ None,
+ )
+ .indent(IndentLevel(1));
edit.replace_all(
while_kw.syntax_element()..=while_cond.syntax().syntax_element(),
- vec![make::token(T![loop]).syntax_element()],
+ vec![make.token(T![loop]).syntax_element()],
);
if is_pattern_cond(while_cond.clone()) {
let then_branch = while_body.reset_indent().indent(IndentLevel(1));
- let if_expr = make::expr_if(while_cond, then_branch, Some(break_block.into()));
- let stmts = iter::once(make::expr_stmt(if_expr.into()).into());
- let block_expr = make::block_expr(stmts, None);
+ let if_expr = make.expr_if(while_cond, then_branch, Some(break_block.into()));
+ let stmts = iter::once(make.expr_stmt(if_expr.into()).into());
+ let block_expr = make.block_expr(stmts, None);
edit.replace(while_body.syntax(), block_expr.indent(while_indent_level).syntax());
} else {
- let if_cond = invert_boolean_expression_legacy(while_cond);
- let if_expr = make::expr_if(if_cond, break_block, None).indent(while_indent_level);
+ let if_cond = invert_boolean_expression(&make, while_cond);
+ let if_expr = make.expr_if(if_cond, break_block, None).indent(while_indent_level);
if !while_body.syntax().text().contains_char('\n') {
edit.insert(
Position::after(&l_curly),
- make::tokens::whitespace(&format!("\n{while_indent_level}")),
+ make.whitespace(&format!("\n{while_indent_level}")),
);
}
edit.insert_all(
Position::after(&l_curly),
vec![
- make::tokens::whitespace(&format!("\n{}", while_indent_level + 1)).into(),
+ make.whitespace(&format!("\n{}", while_indent_level + 1)).into(),
if_expr.syntax().syntax_element(),
],
);
};
+ edit.add_mappings(make.finish_with_mappings());
builder.add_file_edits(ctx.vfs_file_id(), edit);
},
)