bendns' repos / rust-analyzer
Unnamed repository; edit this file 'description' to name the repository.
Diffstat (limited to 'xtask/src/release/changelog.rs')
-rw-r--r--xtask/src/release/changelog.rs54
1 files changed, 36 insertions, 18 deletions
diff --git a/xtask/src/release/changelog.rs b/xtask/src/release/changelog.rs
index 6753841484..817863336d 100644
--- a/xtask/src/release/changelog.rs
+++ b/xtask/src/release/changelog.rs
@@ -30,34 +30,52 @@ pub(crate) fn get_changelog(
// we don't use an HTTPS client or JSON parser to keep the build times low
let pr = pr_num.to_string();
- let pr_json =
- cmd!(sh, "curl -s -H {accept} -H {authorization} {pr_url}/{pr}").read()?;
+ let cmd = &cmd!(sh, "curl --fail -s -H {accept} -H {authorization} {pr_url}/{pr}");
+ let pr_json = match cmd.read() {
+ Ok(pr_json) => pr_json,
+ Err(e) => {
+ // most likely a rust-lang/rust PR
+ eprintln!("Cannot get info for #{pr}: {e}");
+ continue;
+ }
+ };
+
let pr_title = cmd!(sh, "jq .title").stdin(&pr_json).read()?;
let pr_title = unescape(&pr_title[1..pr_title.len() - 1]);
let pr_comment = cmd!(sh, "jq .body").stdin(pr_json).read()?;
- let comments_json =
- cmd!(sh, "curl -s -H {accept} -H {authorization} {pr_url}/{pr}/comments").read()?;
- let pr_comments = cmd!(sh, "jq .[].body").stdin(comments_json).read()?;
-
- let l = iter::once(pr_comment.as_str())
- .chain(pr_comments.lines())
- .rev()
- .find_map(|it| {
- let it = unescape(&it[1..it.len() - 1]);
- it.lines().find_map(parse_changelog_line)
- })
- .into_iter()
- .next()
- .unwrap_or_else(|| parse_title_line(&pr_title));
- let s = match l.kind {
+ let cmd =
+ &cmd!(sh, "curl --fail -s -H {accept} -H {authorization} {pr_url}/{pr}/comments");
+ let pr_info = match cmd.read() {
+ Ok(comments_json) => {
+ let pr_comments = cmd!(sh, "jq .[].body").stdin(comments_json).read()?;
+
+ iter::once(pr_comment.as_str())
+ .chain(pr_comments.lines())
+ .rev()
+ .find_map(|it| {
+ let it = unescape(&it[1..it.len() - 1]);
+ it.lines().find_map(parse_changelog_line)
+ })
+ .into_iter()
+ .next()
+ }
+ Err(e) => {
+ eprintln!("Cannot get comments for #{pr}: {e}");
+ None
+ }
+ };
+
+ let pr_info = pr_info.unwrap_or_else(|| parse_title_line(&pr_title));
+ let s = match pr_info.kind {
PrKind::Feature => &mut features,
PrKind::Fix => &mut fixes,
PrKind::Internal => &mut internal,
PrKind::Other => &mut others,
PrKind::Skip => continue,
};
- writeln!(s, "* pr:{pr_num}[] {}", l.message.as_deref().unwrap_or(&pr_title)).unwrap();
+ writeln!(s, "* pr:{pr_num}[] {}", pr_info.message.as_deref().unwrap_or(&pr_title))
+ .unwrap();
}
}